test: use request_mock for all bound model tests #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 64 64
Lines 2933 2933
=======================================
Hits 2818 2818
Misses 115 115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
No diffs in coverage :) |
apricote
approved these changes
Aug 14, 2025
jooola
added a commit
that referenced
this pull request
Aug 14, 2025
Similar to #536 but focused on the resources clients. Pass request_mock directly to the test functions to configure the mocked HTTP requests. We do not want to update/modify protected properties (the mock object) within the client class. Allows us to move the location of the client request function (that is mocked) in the future, without breaking the tests. This also starts adding typing information to the tests, which should open the door for linting our test code as well. A lot of the diff is from search and replaces and breaking the test arguments onto multiple lines. This is the second patch of a larger set. Based on top of #536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
request_mockdirectly to the test functions to configure the mocked HTTP requests. We do not want to update/modify protected properties (the mock object) within the client class.Allows us to move the location of the client
requestfunction (that is mocked) in the future, without breaking the tests.A lot of the diff is from search and replaces and breaking the test arguments onto multiple lines.
This is the first patch of a larger set. The next step is to use the same technique for the actual API client (not only the bound models).