fix: rename ClientEntityBase to ResourceClientBase
#532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
changed the title
ClientEntityBase to BaseResourceClient ClientEntityBase to BaseResourceClient
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
==========================================
- Coverage 96.07% 96.01% -0.07%
==========================================
Files 64 64
Lines 2933 2938 +5
==========================================
+ Hits 2818 2821 +3
- Misses 115 117 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jooola
force-pushed
the
refactor-rename-resource-base-client
branch
2 times, most recently
from
9da2c2f to
8f0572e
Compare
jooola
changed the title
ClientEntityBase to BaseResourceClient ClientEntityBase to ResourceClientBase
jooola
force-pushed
the
refactor-rename-resource-base-client
branch
from
148f6fb to
0546dea
Compare
Member
Author
|
I'll abuse my powers and merge this:
|
Member
|
Looks good :) |
jooola
changed the title
ClientEntityBase to ResourceClientBase ClientEntityBase to ResourceClientBase
jooola
added a commit
that referenced
this pull request
Sep 8, 2025
<!-- section-start changelog --> ### Features - add category property to server type (#549) ### Bug Fixes - rename `ClientEntityBase` to `ResourceClientBase` (#532) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ```rp-prefix ``` ### Suffix / End This will be added to the end of the release notes. ```rp-suffix ``` </details> --------- Co-authored-by: Hetzner Cloud Bot <> Co-authored-by: jo <ljonas@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rename will reduce confusion in the future when reading the code. The
ClientEntityname does not refer to anything.This is scoped as a fix because the class is public.