fix: handle string id when checking has_id_or_name #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
=======================================
Coverage 92.94% 92.95%
=======================================
Files 64 64
Lines 3020 3023 +3
=======================================
+ Hits 2807 2810 +3
Misses 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jooola
force-pushed
the
handle_stirng_ids_in_has_id_or_name
branch
from
2e59d20 to
c1ac2ac
Compare
The function did not handle the case of string ids (e.g. "2345"), we now handle this edge case. Co-authored-by: Lukas Metzner <lukas.metzner@hetzner-cloud.de>
jooola
force-pushed
the
handle_stirng_ids_in_has_id_or_name
branch
from
c1ac2ac to
8e054c1
Compare
lukasmetzner
approved these changes
Jun 10, 2025
jooola
pushed a commit
that referenced
this pull request
Jun 10, 2025
<!-- section-start changelog --> ### Bug Fixes - invalid placement group id casting (#501) - handle string id when checking has_id_or_name (#504) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ```rp-prefix ``` ### Suffix / End This will be added to the end of the release notes. ```rp-suffix ``` </details> Co-authored-by: releaser-pleaser <>
jooola
pushed a commit
to ansible-collections/hetzner.hcloud
that referenced
this pull request
Jun 10, 2025
##### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Add a test that adding a placement group to a server by ID is idempotent. Verifies fix for #647 <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> ##### ISSUE TYPE <!--- Pick one below and delete the rest --> - Bugfix Pull Request ##### COMPONENT NAME <!--- Write the short name of the module, plugin, task or feature below --> server ##### ADDITIONAL INFORMATION Will pass when the changes introduced in hetznercloud/hcloud-python#504 are available in this module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function did not handle the case of string ids (e.g. "2345"), we now handle this edge case.
Related to ansible-collections/hetzner.hcloud#647