feat: add equality checks to domains #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
reviewed
Mar 17, 2025
jooola
reviewed
Mar 17, 2025
jooola
reviewed
Mar 17, 2025
Member
jooola
left a comment
jooola
left a comment
There was a problem hiding this comment.
Great addition thanks, I am bit worry of the side effects.
Contributor
Author
The good news is that nothing is currently equal, so if we implement a fairly strict equality requirement, I can't imagine we'd have too many negative side-effects. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
==========================================
+ Coverage 92.90% 92.93% +0.02%
==========================================
Files 64 64
Lines 3002 3014 +12
==========================================
+ Hits 2789 2801 +12
Misses 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This allows easier introspection of API responses. Very useful for unit-testing behaviour of wrappers of hcloud.
jooola
reviewed
Mar 19, 2025
jooola
changed the title
jooola
approved these changes
Mar 19, 2025
This was referenced Mar 19, 2025
jooola
pushed a commit
that referenced
this pull request
Mar 19, 2025
<!-- section-start changelog --> ### Features - drop support for python 3.8 (#458) - add equality checks to domains (#481) ### Bug Fixes - server public ipv4 and ipv6 properties are nullable (#455) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ```rp-prefix ``` ### Suffix / End This will be added to the end of the release notes. ```rp-suffix ``` </details> Co-authored-by: releaser-pleaser <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows easier introspection of API responses. Very useful for unit-testing behaviour of wrappers of hcloud.