feat: allow returning root_password in servers rebuild #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
force-pushed
the
server_rebuild_password
branch
2 times, most recently
from
b1559a9 to
703a476
Compare
apricote
approved these changes
Aug 14, 2023
Member
apricote
left a comment
apricote
left a comment
There was a problem hiding this comment.
Looks fine code wise.
Regarding returning different responses based on an argument i think its fine. With the typing people should be informed about it when we change the default.
jooola
force-pushed
the
server_rebuild_password
branch
from
03e74af to
a962a8d
Compare
|
This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs. |
jooola
force-pushed
the
server_rebuild_password
branch
from
a962a8d to
26ebe76
Compare
jooola
pushed a commit
that referenced
this pull request
Nov 17, 2023
🤖 I have created a release *beep* *boop* --- ## [1.32.0](v1.31.0...v1.32.0) (2023-11-17) ### Features * allow returning root_password in servers rebuild ([#276](#276)) ([38e098a](38e098a)) ### Dependencies * update dependency mypy to >=1.7,<1.8 ([#325](#325)) ([7b59a2d](7b59a2d)) * update pre-commit hook pre-commit/mirrors-prettier to v3.1.0 ([#326](#326)) ([213b661](213b661)) * update pre-commit hook psf/black-pre-commit-mirror to v23.10.1 ([#322](#322)) ([999afe3](999afe3)) * update pre-commit hook psf/black-pre-commit-mirror to v23.11.0 ([#324](#324)) ([7b2a24e](7b2a24e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181
Allow returning a full response during the server rebuild by passing an option to the rebuild method. The main reason for this is to not break user land and give users time to upgrade. We also don't want to introduce a new method
rebuild2orrebuild_with_full_responseto keep the API clean.The deprecation timeline is the following:
return_responseargument and deprecated the default behavior (return_response=False)return_responseargument.return_responseargument, or simply leave it unused.