feat: list actions for a given resource #791

jooola · 2025-12-16T11:28:29Z

Adds client.<resource_client>.Action.ListFor(ctx, resource, opts) method to list actions for a resource.
Adds client.<resource_client>.Action.AllFor(ctx, resource, opts) method to list all actions for a resource.

`ResourceActionClient` now has a generic type parameter

The ResourceActionClient struct now has a generic type parameter. The type parameter is used to describe the API resource of the Actions client.

The IResourceActionClient interface that is generated from the ResourceActionClient struct, is also affected by this change.

The API was never intended to be used directly and we did not find any usage of it in public code. So while potentially breaking, the benefits of this change out weighted the risks of doing it.

codecov · 2025-12-16T11:29:34Z

Codecov Report

❌ Patch coverage is 48.00000% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.42%. Comparing base (ff50def) to head (b09f1ea).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
hcloud/certificate.go	0.00%	4 Missing ⚠️
hcloud/firewall.go	0.00%	4 Missing ⚠️
hcloud/floating_ip.go	0.00%	4 Missing ⚠️
hcloud/image.go	0.00%	4 Missing ⚠️
hcloud/load_balancer.go	0.00%	4 Missing ⚠️
hcloud/network.go	0.00%	4 Missing ⚠️
hcloud/server.go	0.00%	4 Missing ⚠️
hcloud/storage_box.go	0.00%	4 Missing ⚠️
hcloud/volume.go	0.00%	4 Missing ⚠️
hcloud/action.go	85.71%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
- Coverage   80.01%   79.42%   -0.60%     
==========================================
  Files          60       60              
  Lines        4494     4553      +59     
==========================================
+ Hits         3596     3616      +20     
- Misses        596      634      +38     
- Partials      302      303       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lukasmetzner

Looks good to me 👍 You can ignore the comment

hcloud/action_test.go

hcloud/action.go

phm07 · 2025-12-18T09:11:30Z

Is there maybe a way to ensure that resources implement the ResourceWithPathID interface? I could see this being accidentally missed for future resources.

jooola · 2025-12-18T13:19:36Z

Is there maybe a way to ensure that resources implement the ResourceWithPathID interface? I could see this being accidentally missed for future resources.

We can have a check that the resource implements the interface. Tests would be the best way to check this.

apricote · 2026-01-07T11:10:33Z

I think the benefits of adding a generic type parameter to ResourceActionClient outweigh the actual impact of it. I did not find any project outside of the CLI that would need to be updated in my search on Sourcegraph and GitHub.

We should still highlight this in the release notes. The usage of the private interface as a constraint for the type parameter should be evaluated in the CLI.

hcloud/action.go

jooola · 2026-01-07T11:46:33Z

Just tried this branch in the CLI project, and no change are required to make this work.

- Adds `client.<resource_client>.Action.ListFor(ctx, id, opts)` method to list actions for a resource identified with the given id. - Adds `client.<resource_client>.Action.AllFor(ctx, id, opts)` method to list all actions for a resource identified with the given id.

### `ResourceActionClient` now has a generic type parameter The [`ResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#ResourceActionClient) struct now has a generic type parameter. The type parameter is used to describe the API resource of the Actions client. The [`IResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#IResourceActionClient) interface that is generated from the [`ResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#ResourceActionClient) struct, is also affected by this change. This API was never intended to be used directly and we did not find any usage of it in public code. So while potentially breaking, the benefits of this change out weighted the risks of doing it. ### Features - retry request on API `timeout` error (#797) - list actions for a given resource (#791)  --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ~~~~rp-prefix ### `ResourceActionClient` now has a generic type parameter The [`ResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#ResourceActionClient) struct now has a generic type parameter. The type parameter is used to describe the API resource of the Actions client. The [`IResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#IResourceActionClient) interface that is generated from the [`ResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#ResourceActionClient) struct, is also affected by this change. This API was never intended to be used directly and we did not find any usage of it in public code. So while potentially breaking, the benefits of this change out weighted the risks of doing it. ~~~~ ### Suffix / End This will be added to the end of the release notes. ~~~~rp-suffix ~~~~ </details> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…4.0 (hetznercloud/fleeting-plugin-hetzner!330) This MR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | `v2.33.0` → `v2.34.0` | ![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fhetznercloud%2fhcloud-go%2fv2/v2.34.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fhetznercloud%2fhcloud-go%2fv2/v2.33.0/v2.34.0?slim=true) | --- ### Release Notes <details> <summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary> ### [`v2.34.0`](https://github.com/hetznercloud/hcloud-go/blob/HEAD/CHANGELOG.md#v2340) [Compare Source](hetznercloud/hcloud-go@v2.33.0...v2.34.0) ##### `ResourceActionClient` now has a generic type parameter The [`ResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#ResourceActionClient) struct now has a generic type parameter. The type parameter is used to describe the API resource of the Actions client. The [`IResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#IResourceActionClient) interface that is generated from the [`ResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#ResourceActionClient) struct, is also affected by this change. This API was never intended to be used directly and we did not find any usage of it in public code. So while potentially breaking, the benefits of this change out weighted the risks of doing it. ##### Features - retry request on API `timeout` error ([#797](hetznercloud/hcloud-go#797)) - list actions for a given resource ([#791](hetznercloud/hcloud-go#791)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

jooola requested a review from a team as a code owner December 16, 2025 11:28

jooola requested review from apricote and lukasmetzner December 16, 2025 11:30

lukasmetzner approved these changes Dec 17, 2025

View reviewed changes

hcloud/action_test.go Show resolved Hide resolved

jooola commented Dec 17, 2025

View reviewed changes

hcloud/action.go Outdated Show resolved Hide resolved

jooola force-pushed the actions-list-for-resource branch from af24d1f to c1e2083 Compare December 19, 2025 15:30

jooola force-pushed the actions-list-for-resource branch from c1e2083 to c29ea99 Compare December 29, 2025 15:42

apricote force-pushed the actions-list-for-resource branch from c29ea99 to 06abfbb Compare January 7, 2026 11:03

jooola commented Jan 7, 2026

View reviewed changes

hcloud/action.go Show resolved Hide resolved

jooola force-pushed the actions-list-for-resource branch from ef5060a to 5f14cb0 Compare January 7, 2026 11:37

jooola requested review from apricote and lukasmetzner and removed request for apricote January 7, 2026 11:44

jooola mentioned this pull request Jan 7, 2026

feat: wait for storage box running actions before retrying hetznercloud/terraform-provider-hcloud#1316

Open

jooola force-pushed the actions-list-for-resource branch from dbc621e to 8d29ed5 Compare January 7, 2026 14:29

jooola and others added 10 commits January 7, 2026 15:55

docs: rename argument name to prevent confusion with action id

bb3bb4c

test: with string resource id

cd2e35b

docs: add example for ResourceActionClient.ListFor

079b88a

using interface

913889e

use type switching

58075f7

feat: generics

3320f92

add argument error handling when getting path id

f2da2b0

chore: rename to noopResource

ce57b86

chore: consistent receiver name

b09f1ea

jooola force-pushed the actions-list-for-resource branch from 8d29ed5 to b09f1ea Compare January 7, 2026 14:56

jooola merged commit 2f1b2b6 into main Jan 7, 2026
4 checks passed

jooola deleted the actions-list-for-resource branch January 7, 2026 15:00

github-actions bot mentioned this pull request Jan 7, 2026

chore(main): release v2.34.0 #798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: list actions for a given resource #791

feat: list actions for a given resource #791

Uh oh!

jooola commented Dec 16, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 16, 2025 •

edited

Loading

Uh oh!

lukasmetzner left a comment

Uh oh!

Uh oh!

Uh oh!

phm07 commented Dec 18, 2025

Uh oh!

jooola commented Dec 18, 2025

Uh oh!

apricote commented Jan 7, 2026

Uh oh!

Uh oh!

jooola commented Jan 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat: list actions for a given resource #791

feat: list actions for a given resource #791

Uh oh!

Conversation

jooola commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ResourceActionClient now has a generic type parameter

Uh oh!

codecov bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lukasmetzner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

phm07 commented Dec 18, 2025

Uh oh!

jooola commented Dec 18, 2025

Uh oh!

apricote commented Jan 7, 2026

Uh oh!

Uh oh!

jooola commented Jan 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jooola commented Dec 16, 2025 •

edited

Loading

`ResourceActionClient` now has a generic type parameter

codecov bot commented Dec 16, 2025 •

edited

Loading