Skip to content

Conversation

@lukasmetzner
Copy link
Contributor

  • remove redundant parsing of full storage box properties
  • make tests more coherent between storage box and the subressources snapshot and subaccount

- remove redundant parsing of full storage box properties
- make tests more coherent between storage box and the subressources snapshot and subaccount
@lukasmetzner lukasmetzner requested a review from a team as a code owner October 13, 2025 11:47
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.39%. Comparing base (9694b91) to head (6b9e007).
⚠️ Report is 1 commits behind head on sbx-api-changes.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           sbx-api-changes     #746      +/-   ##
===================================================
- Coverage            78.42%   78.39%   -0.04%     
===================================================
  Files                   59       59              
  Lines                 5600     5600              
===================================================
- Hits                  4392     4390       -2     
- Misses                 915      917       +2     
  Partials               293      293              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukasmetzner lukasmetzner changed the title refactor: simplify tests refactor(storage-box): simplify tests Oct 13, 2025
@lukasmetzner lukasmetzner requested a review from jooola October 16, 2025 12:16
@lukasmetzner lukasmetzner merged commit ac0c7d3 into sbx-api-changes Oct 16, 2025
3 checks passed
@lukasmetzner lukasmetzner deleted the sbx-refactor-tests branch October 16, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants