feat: add support for Storage Boxes #684

apricote · 2025-08-06T07:37:40Z

We collect all changes for the Storage Box support (#675) in this PR. It will only be merged when everything is implemented through smaller pull requests targetting the storage-boxes branch.

Closes #675

codecov · 2025-08-06T07:38:36Z

Codecov Report

❌ Patch coverage is 79.93139% with 117 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.53%. Comparing base (68c6e74) to head (a9b5ff9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
hcloud/storage_box.go	72.27%	43 Missing and 13 partials ⚠️
hcloud/storage_box_subaccount.go	81.02%	19 Missing and 7 partials ⚠️
hcloud/storage_box_snapshot.go	84.31%	11 Missing and 5 partials ⚠️
hcloud/schema_gen.go	76.66%	6 Missing and 1 partial ⚠️
hcloud/schema.go	87.50%	6 Missing ⚠️
hcloud/storage_box_type.go	86.04%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
+ Coverage   78.24%   78.53%   +0.28%     
==========================================
  Files          55       59       +4     
  Lines        5039     5619     +580     
==========================================
+ Hits         3943     4413     +470     
- Misses        827      912      +85     
- Partials      269      294      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hcloud/storage_box.go

hcloud/schema/storage_box.go

hcloud/storage_box.go

hcloud/storage_box_snapshot.go

hcloud/storage_box_subaccount.go

hcloud/storage_box_snapshot.go

hcloud/storage_box_subaccount.go

hcloud/storage_box.go

jooola

I'll do another pass when the additional changes from #745 are merged.

hcloud/storage_box_snapshot.go

hcloud/storage_box_subaccount.go

hcloud/storage_box_type.go

Adds support for the new Hetzner API with a shallow copy of the original client. The new options `WithHetznerEndpoints` is marked as experimental for now. --------- Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>

We can use the same API endpoint here, as this is a local server for testing, where we define the responses ourselves.

Reference to API docs: https://docs.hetzner.cloud/reference/hetzner#storage-box-types --------- Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>

This PR adds missing schema conversion functions and makes some conversions more consistent with other resources

`hcloud.StorageBox` is part of `hcloud.StorageBoxSubaccount` and `hcloud.StorageBoxSnapshot`. Therefore, we can remove the storage box reference from the function parameters.

Co-authored-by: Jonas L. <jooola@users.noreply.github.com>

jooola · 2025-10-17T09:08:37Z

ℹ️ I am currently fixing a bunch of things here.

jooola · 2025-10-17T12:51:39Z

ℹ️ I am currently fixing a bunch of things here.

Done, please see #752

Additional fixes for the storage boxes implementation.

hcloud/storage_box.go

`ExampleStorageBoxClient_Create` and `ExampleStorageBoxClient_Create` are two examples, which can be expanded in the `func (*StorageBoxClient) [Create]` section of the https://pkg.go.dev/ docs.

Omitted the changelog reference, as there is no sensible one. I have opted for `[StorageBoxClient] is experimental`, as this puts a focus on the hcloud-go integration being experimental instead of the product.

### Storage Box API Experimental This release adds support for the [Storage Box API](https://docs.hetzner.cloud/reference/hetzner#storage-boxes). The Storage Box integration will be introduced as an **experimental** feature. This experimental phase is expected to last until **21 November 2025**. During this period, upcoming minor releases of the project may include breaking changes to features related to the Storage Box API. This release includes all changes from the recent [Storage Box API changelog](https://docs.hetzner.cloud/changelog#2025-10-21-storage-box-api-update) entry. #### Examples ```go result, _, err := client.StorageBox.Create(ctx, hcloud.StorageBoxCreateOpts{ Name: "my-storage-box", StorageBoxType: &hcloud.StorageBoxType{Name: "bx11"}, Location: &hcloud.Location{Name: "fsn1"}, Password: "my-secure-password", SSHKeys: []*hcloud.SSHKey{{ PublicKey: "ssh-rsa AAAAB3NzaC1yc2E..." }}, Labels: map[string]string{"key": "value"}, AccessSettings: &hcloud.StorageBoxCreateOptsAccessSettings{ ReachableExternally: hcloud.Ptr(true), SSHEnabled: hcloud.Ptr(true), }, }) err = client.Action.WaitFor(ctx, result.Action) ``` ### Features - retrieve a server or load balancer network attachment (#750) - add support for Storage Boxes (#684) ### Bug Fixes - deprecate `firewall_already_removed` error code (#748) - invalid property in network add_subnet request body (#751)

…8.0 (hetznercloud/fleeting-plugin-hetzner!294) This MR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | `v2.27.0` -> `v2.28.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fhetznercloud%2fhcloud-go%2fv2/v2.28.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fhetznercloud%2fhcloud-go%2fv2/v2.27.0/v2.28.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary> ### [`v2.28.0`](https://github.com/hetznercloud/hcloud-go/blob/HEAD/CHANGELOG.md#v2280) [Compare Source](hetznercloud/hcloud-go@v2.27.0...v2.28.0) ##### Storage Box API Experimental This release adds support for the [Storage Box API](https://docs.hetzner.cloud/reference/hetzner#storage-boxes). The Storage Box integration will be introduced as an **experimental** feature. This experimental phase is expected to last until **21 November 2025**. During this period, upcoming minor releases of the project may include breaking changes to features related to the Storage Box API. This release includes all changes from the recent [Storage Box API changelog](https://docs.hetzner.cloud/changelog#2025-10-21-storage-box-api-update) entry. ##### Examples ```go result, _, err := client.StorageBox.Create(ctx, hcloud.StorageBoxCreateOpts{ Name: "my-storage-box", StorageBoxType: &hcloud.StorageBoxType{Name: "bx11"}, Location: &hcloud.Location{Name: "fsn1"}, Password: "my-secure-password", SSHKeys: []*hcloud.SSHKey{{ PublicKey: "ssh-rsa AAAAB3NzaC1yc2E..." }}, Labels: map[string]string{"key": "value"}, AccessSettings: &hcloud.StorageBoxCreateOptsAccessSettings{ ReachableExternally: hcloud.Ptr(true), SSHEnabled: hcloud.Ptr(true), }, }) err = client.Action.WaitFor(ctx, result.Action) ``` ##### Features - retrieve a server or load balancer network attachment ([#750](hetznercloud/hcloud-go#750)) - add support for Storage Boxes ([#684](hetznercloud/hcloud-go#684)) ##### Bug Fixes - deprecate `firewall_already_removed` error code ([#748](hetznercloud/hcloud-go#748)) - invalid property in network add\_subnet request body ([#751](hetznercloud/hcloud-go#751)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

apricote assigned lukasmetzner Aug 6, 2025

apricote added the Feature label Aug 6, 2025

lukasmetzner force-pushed the storage-boxes branch from 992641b to 2d340eb Compare August 20, 2025 08:57

phm07 reviewed Aug 20, 2025

View reviewed changes

hcloud/storage_box.go Show resolved Hide resolved

phm07 reviewed Aug 20, 2025

View reviewed changes

hcloud/schema/storage_box.go Outdated Show resolved Hide resolved

lukasmetzner force-pushed the storage-boxes branch from ff07920 to aa5a527 Compare August 26, 2025 09:41

phm07 reviewed Sep 3, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

phm07 reviewed Sep 5, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

phm07 reviewed Sep 8, 2025

View reviewed changes

hcloud/storage_box_snapshot.go Show resolved Hide resolved

hcloud/storage_box_snapshot.go Show resolved Hide resolved

hcloud/storage_box_subaccount.go Show resolved Hide resolved

phm07 reviewed Sep 8, 2025

View reviewed changes

hcloud/storage_box_snapshot.go Show resolved Hide resolved

phm07 reviewed Sep 8, 2025

View reviewed changes

hcloud/storage_box_snapshot.go Outdated Show resolved Hide resolved

phm07 force-pushed the storage-boxes branch from ee914b1 to 39b8d99 Compare September 18, 2025 09:55

phm07 reviewed Sep 18, 2025

View reviewed changes

hcloud/storage_box_subaccount.go Outdated Show resolved Hide resolved

phm07 force-pushed the storage-boxes branch from 39b8d99 to 8c628b8 Compare September 19, 2025 10:59

lukasmetzner force-pushed the storage-boxes branch from a4842c1 to 20e0a5f Compare October 9, 2025 06:54

jooola reviewed Oct 16, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

jooola reviewed Oct 16, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

jooola reviewed Oct 16, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

jooola reviewed Oct 16, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

jooola reviewed Oct 16, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

jooola reviewed Oct 16, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

jooola reviewed Oct 16, 2025

View reviewed changes

lukasmetzner force-pushed the storage-boxes branch 2 times, most recently from a00ef9f to 8a77911 Compare October 17, 2025 06:49

lukasmetzner marked this pull request as ready for review October 17, 2025 07:02

lukasmetzner requested a review from a team as a code owner October 17, 2025 07:02

Lukas Metzner and others added 3 commits October 17, 2025 10:57

feat: add support for Hetzner API endpoint (#683)

eaab4df

Adds support for the new Hetzner API with a shallow copy of the original client. The new options `WithHetznerEndpoints` is marked as experimental for now. --------- Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>

fix: add Hetzner endpoint to test utils (#686)

b5f5b4e

We can use the same API endpoint here, as this is a local server for testing, where we define the responses ourselves.

feat: add support for Storage Box Types (#687)

1b6a3ec

Reference to API docs: https://docs.hetzner.cloud/reference/hetzner#storage-box-types --------- Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>

Lukas Metzner and others added 15 commits October 17, 2025 10:57

feat: map Hetzner API's day_of_week to Go's time.Weekday (#716)

2d0d768

refactor(storage-box): schema conversion functions (#718)

e3dbb28

This PR adds missing schema conversion functions and makes some conversions more consistent with other resources

fix: export missing schema functions

ca80217

fix: description should be optional

856b89c

fix: subresources contain parent (#719)

e04a97c

`hcloud.StorageBox` is part of `hcloud.StorageBoxSubaccount` and `hcloud.StorageBoxSnapshot`. Therefore, we can remove the storage box reference from the function parameters.

refactor: subaccount access settings create opts (#726)

cd5a50a

feat: storage box api changes (#745)

ddd2990

refactor(storage-box): use getByIDOrName helper

7496d17

refactor: parse FromSchema directly in return call

d390bed

feat: remove pointer from descriptions in create calls

1f8b000

feat(snapshot): description is always returned

c8264e8

refactor: print full request path in one line

edadcf3

Co-authored-by: Jonas L. <jooola@users.noreply.github.com>

refactor(storage-box): url query parameter encoding

1c91080

Co-authored-by: Jonas L. <jooola@users.noreply.github.com>

feat(storage-box): delete protection optional

6e0afa7

feat(storage-box): use empty Username for init phase

bf3ac97

jooola force-pushed the storage-boxes branch from 8547e97 to bf3ac97 Compare October 17, 2025 08:57

fix: storage boxes fixes (#752)

be9038e

Additional fixes for the storage boxes implementation.

jooola reviewed Oct 17, 2025

View reviewed changes

hcloud/storage_box.go Show resolved Hide resolved

lukasmetzner reviewed Oct 20, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

Lukas Metzner and others added 3 commits October 20, 2025 13:38

feat(storage-box): use SSH key struct in create opts (#754)

5ceecad

`ExampleStorageBoxClient_Create` and `ExampleStorageBoxClient_Create` are two examples, which can be expanded in the `func (*StorageBoxClient) [Create]` section of the https://pkg.go.dev/ docs.

docs: reference upstream docs in docstrings (#753)

685a945

docs: Storage Box client experimental notice (#756)

a9b5ff9

Omitted the changelog reference, as there is no sensible one. I have opted for `[StorageBoxClient] is experimental`, as this puts a focus on the hcloud-go integration being experimental instead of the product.

jooola approved these changes Oct 21, 2025

View reviewed changes

lukasmetzner merged commit b12e415 into main Oct 21, 2025
3 checks passed

lukasmetzner deleted the storage-boxes branch October 21, 2025 09:19

github-actions bot mentioned this pull request Oct 16, 2025

chore(main): release v2.28.0 #749

Merged

feat: add support for Storage Boxes #684

feat: add support for Storage Boxes #684

Uh oh!

Conversation

apricote commented Aug 6, 2025

Uh oh!

codecov bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jooola left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jooola commented Oct 17, 2025

Uh oh!

jooola commented Oct 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Aug 6, 2025 •

edited

Loading