fix: device needs to be ready on node publish - #1381
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor-loop-through-context #1381 +/- ##
=================================================================
+ Coverage 71.97% 72.17% +0.19%
=================================================================
Files 17 17
Lines 1495 1520 +25
=================================================================
+ Hits 1076 1097 +21
- Misses 333 336 +3
- Partials 86 87 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| backoffFunc := hcloud.ExponentialBackoffWithOpts(hcloud.ExponentialBackoffOpts{ | ||
| Base: time.Millisecond * 50, | ||
| Multiplier: 2.0, | ||
| Cap: 500 * time.Millisecond, | ||
| }) |
There was a problem hiding this comment.
With a 500ms cap, we might as well just wait 500ms every time. What is the reason for having such a small cap? Could we increase the cap to e.g. 5s?
(Without cap, we would have a total waiting time of 12.8 seconds, with a max of 7 retries)
There was a problem hiding this comment.
We don't fully understand yet why this device appears late. Talking with internal teams, one idea is that the OS is under heavy pressure. This seems to happen very rarely, as we don't have a lot of issue reports from customers.
My idea was to quickly retry in small intervals, to absorb the delays caused by the OS being busy.
### Bug Fixes - device needs to be ready on node publish (#1381)
No description provided.