Skip to content

fix: device needs to be ready on node publish - #1381

Merged
lukasmetzner merged 2 commits into
refactor-loop-through-contextfrom
fix-node-publish-wait-device-ready
May 29, 2026
Merged

fix: device needs to be ready on node publish#1381
lukasmetzner merged 2 commits into
refactor-loop-through-contextfrom
fix-node-publish-wait-device-ready

Conversation

@lukasmetzner

Copy link
Copy Markdown
Contributor

No description provided.

@lukasmetzner
lukasmetzner requested a review from a team as a code owner May 29, 2026 06:57
@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.17%. Comparing base (29289b1) to head (d7586bf).

Files with missing lines Patch % Lines
internal/volumes/mount.go 85.18% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           refactor-loop-through-context    #1381      +/-   ##
=================================================================
+ Coverage                          71.97%   72.17%   +0.19%     
=================================================================
  Files                                 17       17              
  Lines                               1495     1520      +25     
=================================================================
+ Hits                                1076     1097      +21     
- Misses                               333      336       +3     
- Partials                              86       87       +1     
Flag Coverage Δ
e2e-controller 56.90% <85.18%> (+0.45%) ⬆️
e2e-node 56.90% <85.18%> (+0.45%) ⬆️
integration 3.19% <0.00%> (-0.08%) ⬇️
unit 40.85% <0.00%> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread internal/volumes/mount.go
Comment on lines +170 to +174
backoffFunc := hcloud.ExponentialBackoffWithOpts(hcloud.ExponentialBackoffOpts{
Base: time.Millisecond * 50,
Multiplier: 2.0,
Cap: 500 * time.Millisecond,
})

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a 500ms cap, we might as well just wait 500ms every time. What is the reason for having such a small cap? Could we increase the cap to e.g. 5s?

(Without cap, we would have a total waiting time of 12.8 seconds, with a max of 7 retries)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't fully understand yet why this device appears late. Talking with internal teams, one idea is that the OS is under heavy pressure. This seems to happen very rarely, as we don't have a lot of issue reports from customers.

My idea was to quickly retry in small intervals, to absorb the delays caused by the OS being busy.

@lukasmetzner
lukasmetzner merged commit 57eb782 into refactor-loop-through-context May 29, 2026
10 checks passed
@lukasmetzner
lukasmetzner deleted the fix-node-publish-wait-device-ready branch May 29, 2026 12:53
lukasmetzner pushed a commit that referenced this pull request Jun 1, 2026
### Bug Fixes

- device needs to be ready on node publish (#1381)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants