fix: filepaths not correctly resolved on Windows #1229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1229 +/- ##
=======================================
Coverage 72.28% 72.28%
=======================================
Files 311 311
Lines 11407 11407
=======================================
Hits 8245 8245
Misses 2216 2216
Partials 946 946
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Should we run some tests in windows? |
jooola
approved these changes
Nov 7, 2025
Contributor
Author
Yeah, I think that would make sense |
jooola
pushed a commit
that referenced
this pull request
Nov 7, 2025
<!-- section-start changelog --> ### Features - format user provided TXT records when not quoted (#1208) ### Bug Fixes - more readable default time format (#1197) - **iso**: broken `--type` flag in list command (#1221) - Storage Boxes not listed in `hcloud all list` (#1222) - consistent tab spacing in describe commands (#1216) - filepaths not correctly resolved on Windows (#1229) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ~~~~rp-prefix ~~~~ ### Suffix / End This will be added to the end of the release notes. ~~~~rp-suffix ~~~~ </details> Co-authored-by: Hetzner Cloud Bot <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path package only supports slash-separated paths. We should use filepath for platform-specific path handling instead.
Fixes #1225