Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node version & ci updates #108

Merged
merged 3 commits into from
Nov 9, 2020
Merged

fix: node version & ci updates #108

merged 3 commits into from
Nov 9, 2020

Conversation

hertzg
Copy link
Owner

@hertzg hertzg commented Nov 9, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

Report for v1.3.10-0-unreleased.pr108.98

📦 Packing output
npm notice 
npm notice 📦  net-keepalive@1.3.10-0-unreleased.pr108.98
npm notice === Tarball Contents === 
npm notice 1.1kB LICENSE            
npm notice 918B  lib/commons.js     
npm notice 479B  lib/constants.js   
npm notice 963B  lib/ffi-bindings.js
npm notice 34B   index.js           
npm notice 6.3kB lib/index.js       
npm notice 2.1kB package.json       
npm notice 2.9kB CHANGELOG.md       
npm notice 5.5kB README.md          
npm notice 742B  index.d.ts         
npm notice === Tarball Details === 
npm notice name:          net-keepalive                                 
npm notice version:       1.3.10-0-unreleased.pr108.98                  
npm notice filename:      net-keepalive-1.3.10-0-unreleased.pr108.98.tgz
npm notice package size:  6.5 kB                                        
npm notice unpacked size: 20.9 kB                                       
npm notice shasum:        40ff40dbb5d907296e3c62bc0bfe0dcb45819b1e      
npm notice integrity:     sha512-/4qCVsSjsZrpX[...]RijPlihPR6ngg==      
npm notice total files:   10                                            
npm notice 
⚡ Install log in dependent packages

> ref-napi@2.1.2 install /tmp/tmp.BCZguRy8mK/node_modules/ffi-napi/node_modules/ref-napi
> node-gyp-build


> ffi-napi@3.0.1 install /tmp/tmp.BCZguRy8mK/node_modules/ffi-napi
> node-gyp-build

make: Entering directory '/tmp/tmp.BCZguRy8mK/node_modules/ffi-napi/build'
CC(target) Release/obj.target/nothing/../node-addon-api/src/nothing.o
AR(target) Release/obj.target/../node-addon-api/src/nothing.a
COPY Release/nothing.a
CC(target) Release/obj.target/ffi/deps/libffi/src/prep_cif.o
CC(target) Release/obj.target/ffi/deps/libffi/src/types.o
CC(target) Release/obj.target/ffi/deps/libffi/src/raw_api.o
CC(target) Release/obj.target/ffi/deps/libffi/src/java_raw_api.o
CC(target) Release/obj.target/ffi/deps/libffi/src/closures.o
../deps/libffi/src/closures.c: In function ‘dlmmap_locked’:
../deps/libffi/src/closures.c:421:7: warning: ignoring return value of ‘ftruncate’, declared with attribute warn_unused_result [-Wunused-result]
     ftruncate (execfd, offset);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/libffi/src/closures.c:433:7: warning: ignoring return value of ‘ftruncate’, declared with attribute warn_unused_result [-Wunused-result]
     ftruncate (execfd, offset);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
CC(target) Release/obj.target/ffi/deps/libffi/src/x86/ffi.o
CC(target) Release/obj.target/ffi/deps/libffi/src/x86/ffi64.o
../deps/libffi/src/x86/ffi64.c: In function ‘classify_argument’:
../deps/libffi/src/x86/ffi64.c:181:18: warning: suggest braces around empty body in an ‘else’ statement [-Wempty-body]
  FFI_ASSERT (0);
                ^
../deps/libffi/src/x86/ffi64.c:156:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
     {
     ^
../deps/libffi/src/x86/ffi64.c:183:5: note: here
   case FFI_TYPE_FLOAT:
   ^~~~
CC(target) Release/obj.target/ffi/deps/libffi/src/x86/unix64.o
CC(target) Release/obj.target/ffi/deps/libffi/src/x86/sysv.o
AR(target) Release/obj.target/deps/libffi/libffi.a
COPY Release/libffi.a
CXX(target) Release/obj.target/ffi_bindings/src/ffi.o
In file included from ../src/ffi.cc:3:0:
../src/ffi.h:148:19: warning: mangled name for ‘Napi::TypedArray FFI::WrapPointer(Napi::Env, T*, size_t) [with T = char*() throw ()]’ will change in C++17 because the exception specification is part of a function type [-Wnoexcept-type]
inline TypedArray WrapPointer(Env env, T* ptr, size_t length = 0) {
                 ^~~~~~~~~~~
../src/ffi.h:148:19: warning: mangled name for ‘Napi::TypedArray FFI::WrapPointer(Napi::Env, T*, size_t) [with T = void*(void*, const char*) throw ()]’ will change in C++17 because the exception specification is part of a function type [-Wnoexcept-type]
../src/ffi.h:148:19: warning: mangled name for ‘Napi::TypedArray FFI::WrapPointer(Napi::Env, T*, size_t) [with T = int(void*) throw ()]’ will change in C++17 because the exception specification is part of a function type [-Wnoexcept-type]
../src/ffi.h:148:19: warning: mangled name for ‘Napi::TypedArray FFI::WrapPointer(Napi::Env, T*, size_t) [with T = void*(const char*, int) throw ()]’ will change in C++17 because the exception specification is part of a function type [-Wnoexcept-type]
CXX(target) Release/obj.target/ffi_bindings/src/callback_info.o
CXX(target) Release/obj.target/ffi_bindings/src/threaded_callback_invokation.o
SOLINK_MODULE(target) Release/obj.target/ffi_bindings.node
COPY Release/ffi_bindings.node
make: Leaving directory '/tmp/tmp.BCZguRy8mK/node_modules/ffi-napi/build'

> ref-napi@3.0.1 install /tmp/tmp.BCZguRy8mK/node_modules/ref-napi
> node-gyp-build

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN tmp.BCZguRy8mK@1.0.0 No description
npm WARN tmp.BCZguRy8mK@1.0.0 No repository field.

+ net-keepalive@1.3.10-0-unreleased.pr108.98
added 12 packages from 60 contributors and audited 12 packages in 9.007s
found 0 vulnerabilities
ℹ️ Dependencies installed in dependent packages
tmp.BCZguRy8mK@1.0.0 /tmp/tmp.BCZguRy8mK
└─┬ net-keepalive@1.3.10-0-unreleased.pr108.98
├── ffi-napi@3.0.1
└── ref-napi@3.0.1
📊 Installed size of node_modules in dependent packages
68K	node_modules/debug
9.7M	node_modules/ffi-napi
40K	node_modules/get-symbol-from-current-process-h
40K	node_modules/get-uv-event-loop-napi-h
20K	node_modules/ms
56K	node_modules/net-keepalive
960K	node_modules/node-addon-api
36K	node_modules/node-gyp-build
2.5M	node_modules/ref-napi
204K	node_modules/ref-struct-di
14M	total

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #108 (42587fd) into master (276711b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #108   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           98        98           
=========================================
  Hits            98        98           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4766b02...42587fd. Read the comment docs.

@hertzg hertzg changed the base branch from master to rel-proposal November 9, 2020 20:57
@hertzg hertzg merged commit 62b9084 into rel-proposal Nov 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hertzg hertzg deleted the fix-node-version branch November 9, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant