fix(date-input): fixed description and error overflow #5227

Vishvsalvi · 2025-04-22T18:47:44Z

Closes #3515

📝 Description

The description and error message was overflowing when the label placement was "outside" or "left-outside"

⛳️ Current behavior (updates)

The current changes avoid overflowing of description and error message

🚀 New behavior

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Summary by CodeRabbit

New Features
- Added a new label placement option ("inside", "outside", or "outside-left") for the date input component, allowing for more flexible label positioning.
Bug Fixes
- Improved handling of description and error messages in the date input to prevent overflow and enhance visual presentation.
Style
- Updated layout and alignment styles for date input labels and helper messages to support the new label placement options and improve appearance.

changeset-bot · 2025-04-22T18:47:47Z

🦋 Changeset detected

Latest commit: d0e2520

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@heroui/date-input	Patch
@heroui/theme	Patch
@heroui/date-picker	Patch
@heroui/react	Patch
@heroui/autocomplete	Patch
@heroui/checkbox	Patch
@heroui/form	Patch
@heroui/input-otp	Patch
@heroui/input	Patch
@heroui/number-input	Patch
@heroui/radio	Patch
@heroui/select	Patch
@heroui/table	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-04-22T18:47:48Z

@Vishvsalvi is attempting to deploy a commit to the HeroUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2025-04-22T18:47:51Z

"""

Walkthrough

The changes introduce a new labelPlacement prop to the DateInputGroup component, adjust the rendering logic and DOM structure based on this prop, and update related styling in the theme to address overflow and alignment issues for descriptions and errors. Package dependencies are also updated accordingly.

Changes

File(s)	Change Summary
packages/components/date-input/src/date-input-group.tsx	Added `labelPlacement` prop, refactored rendering logic for new layout variant, adjusted DOM structure.
packages/components/date-input/src/use-date-input.ts	Included `labelPlacement` in the object returned by `getBaseGroupProps`.
packages/core/theme/src/components/date-input.ts	Modified styles for helper wrapper and label alignment; removed relative/absolute positioning.
packages/components/date-input/package.json	Updated peer dependency for `@heroui/theme` to version `>=2.4.17`.
.changeset/twenty-clocks-cross.md	Added changeset documenting the fix for description and error overflow in date input.

Sequence Diagram(s)

sequenceDiagram
    participant Parent as Parent Component
    participant DateInputGroup as DateInputGroup
    participant Theme as Theme Styles

    Parent->>DateInputGroup: Render with labelPlacement prop
    DateInputGroup->>DateInputGroup: Determine layout based on labelPlacement
    DateInputGroup->>Theme: Apply styles for helperWrapper and label
    DateInputGroup-->>Parent: Rendered DateInputGroup with correct layout and style

Assessment against linked issues

Objective	Addressed	Explanation
Fix DateInput description and error overflow; ensure help text separates and does not overflow (#3515)	✅

Suggested reviewers

jrgarciadev
"""

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3d208de and d0e2520.

📒 Files selected for processing (2)

packages/components/date-input/package.json (1 hunks)
packages/components/date-input/src/use-date-input.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

packages/components/date-input/src/use-date-input.ts
packages/components/date-input/package.json

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: Continuous Release
GitHub Check: TypeScript
GitHub Check: ESLint
GitHub Check: Tests
GitHub Check: Build

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-04-23T02:52:43Z

Open in StackBlitz

@heroui/accordion

npm i https://pkg.pr.new/@heroui/accordion@5227

@heroui/alert

npm i https://pkg.pr.new/@heroui/alert@5227

@heroui/autocomplete

npm i https://pkg.pr.new/@heroui/autocomplete@5227

@heroui/avatar

npm i https://pkg.pr.new/@heroui/avatar@5227

@heroui/badge

npm i https://pkg.pr.new/@heroui/badge@5227

@heroui/breadcrumbs

npm i https://pkg.pr.new/@heroui/breadcrumbs@5227

@heroui/button

npm i https://pkg.pr.new/@heroui/button@5227

@heroui/calendar

npm i https://pkg.pr.new/@heroui/calendar@5227

@heroui/card

npm i https://pkg.pr.new/@heroui/card@5227

@heroui/checkbox

npm i https://pkg.pr.new/@heroui/checkbox@5227

@heroui/chip

npm i https://pkg.pr.new/@heroui/chip@5227

@heroui/code

npm i https://pkg.pr.new/@heroui/code@5227

@heroui/date-input

npm i https://pkg.pr.new/@heroui/date-input@5227

@heroui/date-picker

npm i https://pkg.pr.new/@heroui/date-picker@5227

@heroui/divider

npm i https://pkg.pr.new/@heroui/divider@5227

@heroui/drawer

npm i https://pkg.pr.new/@heroui/drawer@5227

@heroui/dropdown

npm i https://pkg.pr.new/@heroui/dropdown@5227

@heroui/form

npm i https://pkg.pr.new/@heroui/form@5227

@heroui/image

npm i https://pkg.pr.new/@heroui/image@5227

@heroui/input

npm i https://pkg.pr.new/@heroui/input@5227

@heroui/input-otp

npm i https://pkg.pr.new/@heroui/input-otp@5227

@heroui/kbd

npm i https://pkg.pr.new/@heroui/kbd@5227

@heroui/link

npm i https://pkg.pr.new/@heroui/link@5227

@heroui/listbox

npm i https://pkg.pr.new/@heroui/listbox@5227

@heroui/menu

npm i https://pkg.pr.new/@heroui/menu@5227

@heroui/modal

npm i https://pkg.pr.new/@heroui/modal@5227

@heroui/navbar

npm i https://pkg.pr.new/@heroui/navbar@5227

@heroui/number-input

npm i https://pkg.pr.new/@heroui/number-input@5227

@heroui/pagination

npm i https://pkg.pr.new/@heroui/pagination@5227

@heroui/popover

npm i https://pkg.pr.new/@heroui/popover@5227

@heroui/progress

npm i https://pkg.pr.new/@heroui/progress@5227

@heroui/radio

npm i https://pkg.pr.new/@heroui/radio@5227

@heroui/ripple

npm i https://pkg.pr.new/@heroui/ripple@5227

@heroui/scroll-shadow

npm i https://pkg.pr.new/@heroui/scroll-shadow@5227

@heroui/select

npm i https://pkg.pr.new/@heroui/select@5227

@heroui/skeleton

npm i https://pkg.pr.new/@heroui/skeleton@5227

@heroui/slider

npm i https://pkg.pr.new/@heroui/slider@5227

@heroui/snippet

npm i https://pkg.pr.new/@heroui/snippet@5227

@heroui/spacer

npm i https://pkg.pr.new/@heroui/spacer@5227

@heroui/spinner

npm i https://pkg.pr.new/@heroui/spinner@5227

@heroui/switch

npm i https://pkg.pr.new/@heroui/switch@5227

@heroui/table

npm i https://pkg.pr.new/@heroui/table@5227

@heroui/tabs

npm i https://pkg.pr.new/@heroui/tabs@5227

@heroui/toast

npm i https://pkg.pr.new/@heroui/toast@5227

@heroui/tooltip

npm i https://pkg.pr.new/@heroui/tooltip@5227

@heroui/user

npm i https://pkg.pr.new/@heroui/user@5227

@heroui/react

npm i https://pkg.pr.new/@heroui/react@5227

@heroui/system

npm i https://pkg.pr.new/@heroui/system@5227

@heroui/system-rsc

npm i https://pkg.pr.new/@heroui/system-rsc@5227

@heroui/theme

npm i https://pkg.pr.new/@heroui/theme@5227

@heroui/use-aria-accordion

npm i https://pkg.pr.new/@heroui/use-aria-accordion@5227

@heroui/use-aria-accordion-item

npm i https://pkg.pr.new/@heroui/use-aria-accordion-item@5227

@heroui/use-aria-button

npm i https://pkg.pr.new/@heroui/use-aria-button@5227

@heroui/use-aria-link

npm i https://pkg.pr.new/@heroui/use-aria-link@5227

@heroui/use-aria-modal-overlay

npm i https://pkg.pr.new/@heroui/use-aria-modal-overlay@5227

@heroui/use-aria-multiselect

npm i https://pkg.pr.new/@heroui/use-aria-multiselect@5227

@heroui/use-callback-ref

npm i https://pkg.pr.new/@heroui/use-callback-ref@5227

@heroui/use-clipboard

npm i https://pkg.pr.new/@heroui/use-clipboard@5227

@heroui/use-data-scroll-overflow

npm i https://pkg.pr.new/@heroui/use-data-scroll-overflow@5227

@heroui/use-disclosure

npm i https://pkg.pr.new/@heroui/use-disclosure@5227

@heroui/use-draggable

npm i https://pkg.pr.new/@heroui/use-draggable@5227

@heroui/use-image

npm i https://pkg.pr.new/@heroui/use-image@5227

@heroui/use-infinite-scroll

npm i https://pkg.pr.new/@heroui/use-infinite-scroll@5227

@heroui/use-intersection-observer

npm i https://pkg.pr.new/@heroui/use-intersection-observer@5227

@heroui/use-is-mobile

npm i https://pkg.pr.new/@heroui/use-is-mobile@5227

@heroui/use-is-mounted

npm i https://pkg.pr.new/@heroui/use-is-mounted@5227

@heroui/use-measure

npm i https://pkg.pr.new/@heroui/use-measure@5227

@heroui/use-pagination

npm i https://pkg.pr.new/@heroui/use-pagination@5227

@heroui/use-real-shape

npm i https://pkg.pr.new/@heroui/use-real-shape@5227

@heroui/use-ref-state

npm i https://pkg.pr.new/@heroui/use-ref-state@5227

@heroui/use-resize

npm i https://pkg.pr.new/@heroui/use-resize@5227

@heroui/use-safe-layout-effect

npm i https://pkg.pr.new/@heroui/use-safe-layout-effect@5227

@heroui/use-scroll-position

npm i https://pkg.pr.new/@heroui/use-scroll-position@5227

@heroui/use-ssr

npm i https://pkg.pr.new/@heroui/use-ssr@5227

@heroui/use-theme

npm i https://pkg.pr.new/@heroui/use-theme@5227

@heroui/use-update-effect

npm i https://pkg.pr.new/@heroui/use-update-effect@5227

@heroui/aria-utils

npm i https://pkg.pr.new/@heroui/aria-utils@5227

@heroui/dom-animation

npm i https://pkg.pr.new/@heroui/dom-animation@5227

@heroui/framer-utils

npm i https://pkg.pr.new/@heroui/framer-utils@5227

@heroui/react-rsc-utils

npm i https://pkg.pr.new/@heroui/react-rsc-utils@5227

@heroui/react-utils

npm i https://pkg.pr.new/@heroui/react-utils@5227

@heroui/shared-icons

npm i https://pkg.pr.new/@heroui/shared-icons@5227

@heroui/shared-utils

npm i https://pkg.pr.new/@heroui/shared-utils@5227

@heroui/stories-utils

npm i https://pkg.pr.new/@heroui/stories-utils@5227

@heroui/test-utils

npm i https://pkg.pr.new/@heroui/test-utils@5227

commit: d0e2520

vercel · 2025-05-24T16:43:19Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
heroui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 29, 2025 6:13am
heroui-sb	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 29, 2025 6:13am

packages/components/date-input/src/date-input-group.tsx

Vishvsalvi · 2025-05-26T19:14:55Z

Done 👍

packages/components/date-input/src/date-input-group.tsx

.changeset/date-input-label-placement.md

Vishvsalvi · 2025-05-31T16:58:12Z

Done 👍

wingkwong

As mentioned by Junior, absolute should be required in some cases. Please double check.

fix(date-input): fixed description and error overflow

5e8e60c

Vishvsalvi requested a review from jrgarciadev as a code owner April 22, 2025 18:47

wingkwong requested changes May 24, 2025

View reviewed changes

packages/components/date-input/src/date-input-group.tsx Outdated Show resolved Hide resolved

wingkwong assigned Vishvsalvi May 24, 2025

wingkwong added the 🚧 Status: Changes Requested label May 24, 2025

vercel bot deployed to Preview – heroui May 24, 2025 16:48 View deployment

vercel bot deployed to Preview – heroui-sb May 24, 2025 16:50 View deployment

Vishvsalvi added 2 commits May 27, 2025 00:40

Update use-date-input.ts

5c12407

Update date-input-group.tsx

a7615c0

vercel bot deployed to Preview – heroui May 27, 2025 12:38 View deployment

vercel bot deployed to Preview – heroui-sb May 27, 2025 12:41 View deployment

wingkwong added 3 commits May 27, 2025 20:51

chore(date-input): format

f3fa475

Merge branch 'canary' into pr/5227

ee98e72

Merge branch 'canary' into pr/5227

ac7fdd0

wingkwong requested changes May 27, 2025

View reviewed changes

packages/components/date-input/src/date-input-group.tsx Outdated Show resolved Hide resolved

.changeset/date-input-label-placement.md Outdated Show resolved Hide resolved

Update date-input-label-placement.md

f67a359

vercel bot deployed to Preview – heroui-sb May 31, 2025 03:52 View deployment

vercel bot deployed to Preview – heroui May 31, 2025 03:53 View deployment

Update date-input-group.tsx

f30e0ca

refactor(date-input): prettier

00e9c44

wingkwong added 👀 Status: To Review and removed 🚧 Status: Changes Requested labels Jun 1, 2025

wingkwong self-assigned this Jun 1, 2025

wingkwong unassigned Vishvsalvi Jun 1, 2025

vercel bot deployed to Preview – heroui June 1, 2025 02:22 View deployment

vercel bot deployed to Preview – heroui-sb June 1, 2025 02:24 View deployment

wingkwong added 3 commits June 1, 2025 13:09

refactor(date-input): use lower case

92db5c5

refactor(changeset): update changeset

8aa4c94

chore(date-input): bump peerDependencies of theme package

b4b8a12

vercel bot deployed to Preview – heroui June 1, 2025 05:18 View deployment

vercel bot deployed to Preview – heroui-sb June 1, 2025 05:20 View deployment

wingkwong removed the 👀 Status: To Review label Jun 1, 2025

wingkwong removed their assignment Jun 1, 2025

wingkwong added this to the v2.7.9 milestone Jun 1, 2025

wingkwong approved these changes Jun 1, 2025

View reviewed changes

wingkwong assigned jrgarciadev Jun 1, 2025

jrgarciadev modified the milestones: v2.7.9, v2.8.0 Jun 1, 2025

wingkwong added 3 commits June 2, 2025 20:48

Merge branch 'canary' into pr/5227

ec74ab9

Merge branch 'canary' into pr/5227

3d208de

Merge branch 'canary' into pr/5227

d0e2520

vercel bot deployed to Preview – heroui June 29, 2025 06:11 View deployment

vercel bot deployed to Preview – heroui-sb June 29, 2025 06:13 View deployment

wingkwong removed this from the v2.8.0 milestone Jul 8, 2025

wingkwong reviewed Jul 8, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(date-input): fixed description and error overflow #5227

fix(date-input): fixed description and error overflow #5227

Uh oh!

Vishvsalvi commented Apr 22, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Apr 22, 2025 •

edited

Loading

Uh oh!

vercel bot commented Apr 22, 2025

Uh oh!

coderabbitai bot commented Apr 22, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

pkg-pr-new bot commented Apr 23, 2025 •

edited

Loading

Uh oh!

vercel bot commented May 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Vishvsalvi commented May 26, 2025

Uh oh!

Uh oh!

Uh oh!

Vishvsalvi commented May 31, 2025

Uh oh!

wingkwong left a comment

Uh oh!

Uh oh!

Uh oh!

fix(date-input): fixed description and error overflow #5227

Are you sure you want to change the base?

fix(date-input): fixed description and error overflow #5227

Uh oh!

Conversation

Vishvsalvi commented Apr 22, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Apr 22, 2025

Uh oh!

coderabbitai bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

pkg-pr-new bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented May 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Vishvsalvi commented May 26, 2025

Uh oh!

Uh oh!

Uh oh!

Vishvsalvi commented May 31, 2025

Uh oh!

wingkwong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Vishvsalvi commented Apr 22, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Apr 22, 2025 •

edited

Loading

coderabbitai bot commented Apr 22, 2025 •

edited

Loading

pkg-pr-new bot commented Apr 23, 2025 •

edited

Loading

vercel bot commented May 24, 2025 •

edited

Loading