Docopt #38
Merged
Docopt #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still need to do:
|
jtatusko
commented
Jan 7, 2019
adept/environments/env_registry.py
Outdated
|
|
||
| def lookup_env_class(self, env_id): | ||
| engine = self.lookup_engine(env_id) | ||
| return self.plugin_class_by_engine_id[engine] | ||
| return self._plugin_class_by_engine_id[engine] |
There was a problem hiding this comment.
_module_class_by_engine_id
jtatusko
commented
Jan 7, 2019
adept/environments/_metadata.py
Outdated
| @@ -34,15 +34,15 @@ def __init__(self, env_plugin_class, args): | |||
| self._gpu_preprocessor = dummy_env.gpu_preprocessor | |||
|
|
|||
| @classmethod | |||
| def from_args(cls, args, registry=EnvPluginRegistry()): | |||
| def from_args(cls, args, registry=EnvModuleRegistry()): | |||
| """ | |||
| Mimic the AdeptEnvPlugin.from_args API to simplify interface. | |||
jtatusko
commented
Jan 7, 2019
adept/environments/_metadata.py
Outdated
| """ | ||
| Mimic the AdeptEnvPlugin.from_args API to simplify interface. | ||
|
|
||
| :param args: Arguments object | ||
| :param registry: Optionally provide to avoid recreating. | ||
| :return: EnvMetaData | ||
| """ | ||
| plugin_class = registry.lookup_env_class(args.env_id) | ||
| plugin_class = registry.lookup_env_class(args.env) |
jtatusko
commented
Jan 7, 2019
| @@ -63,38 +66,62 @@ class Engines(IntEnum): | |||
| ] | |||
|
|
|||
|
|
|||
| class EnvPluginRegistry: | |||
| class EnvModuleRegistry: | |||
| """ | |||
| Keeps track of supported environment plugins. | |||
| """ | |||
jtatusko
commented
Jan 7, 2019
adept/environments/env_registry.py
Outdated
| self.engine_ids_by_env_id_set = {} | ||
| self.plugin_class_by_engine_id = {} | ||
| self._engine_ids_by_env_id_set = {} | ||
| self._plugin_class_by_engine_id = {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.