Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error messages for buildpack packaging failures #720

Merged
merged 2 commits into from
Nov 7, 2023

Commits on Nov 6, 2023

  1. Fix error messages for buildpack packaging failures

    After #666, incorrect error messages were shown for failures that
    occurred during buildpack compilation packaging, since the
    handling in `TestRunner::build_internal` used the wrong message
    text, plus didn't include the error struct in the `panic!` string.
    
    These have been fixed, plus display representations added to
    all of the new error variants.
    
    In addition, the usages of `assert!` and `.unwrap()` in functions that
    return `Result` have been replaced with new error enum variants.
    
    The change in output can be seen in the new tests added by #717.
    
    There is one last scenario that doesn't yet have a test - the testing
    of the cross-compilation output itself. However, I'll add that separately,
    since it's going to be more complex to test / there are a few different
    options that we'll need to choose between.
    
    Fixes #704.
    Fixes #709.
    Fixes #710.
    GUS-W-14395170.
    edmorley committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    9504a2c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. #[error(transparent)]

    edmorley committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    cfd3c3d View commit details
    Browse the repository at this point in the history