Improve NLTK downloader log output and error messages #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
force-pushed
the
nltk-error-handling
branch
from
f2c6c3b
to
d604629
Compare
runesoerensen
approved these changes
Nov 8, 2024
colincasey
reviewed
Nov 8, 2024
colincasey
approved these changes
Nov 8, 2024
Improves the build log output, error messages and buildpack failure metrics for the NLTK downloader feature, and adds a test for the app having an invalid `nltk.txt` (since previously only the successful cases were tested). This should be the last failure type seen in the wild that doesn't emit a `failure_reason` metric. GUS-W-8059892.
edmorley
force-pushed
the
nltk-error-handling
branch
from
d604629
to
6d2084f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the build log output, error messages and buildpack failure metrics for the NLTK downloader feature, and adds a test for the app having an invalid
nltk.txt(since previously only the successful cases were tested).This should be the last failure type seen in the wild that doesn't emit a
failure_reasonmetric.GUS-W-8059892.