Improve output utils for warnings, steps and indented output #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
force-pushed
the
refactor-output-utils
branch
from
4003a05
to
5e4134c
Compare
* Switches warnings to the same approach used for errors (which also adds colour) * Switches to the new style utils for steps + indentation * Removes usage of the `exec 1>&2` pattern since it breaks the output returned by Bash functions, amongst other issues. GUS-W-17048951.
edmorley
force-pushed
the
refactor-output-utils
branch
from
5e4134c
to
df09ba4
Compare
Malax
approved these changes
Oct 23, 2024
edmorley
added a commit
that referenced
this pull request
Oct 25, 2024
In #1666 the API for `output::error` was simplified, such that it only supports the message being passed via stdin (since that's the pattern used when passing a multi-line HERE-doc, and we want to encourage detailed error messages). However, there were a couple of remaining instances not switched over to the stdin API. These usages are in codepaths that cannot be tested via integration tests since they are unreachable unless there was an internal buildpack bug. (And Shellcheck also didn't spot these instances of unconsumed passed args.) GUS-W-17048951.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exec 1>&2pattern since it breaks the output returned by Bash functions, amongst other issues.GUS-W-17048951.