Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additional occurrence of yarn cache nesting #987

Merged
merged 4 commits into from
Feb 16, 2022

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Feb 16, 2022

The current yarn cache restore logic (introduced in #978) can create nested caches like below, iff the .yarn/cache folder is committed in the repo, but empty.

- node
  - cache
    - yarn
      - yarn
        - yarn
          - yarn

This PR changes the cache restore logic to remove the empty folder before moving the cache, so we essentially replace the folder, rather than nesting folders.

This also adds some temporary logic to delete any nested caches we created in #978.

GUS-W-10519616

@joshwlewis joshwlewis requested a review from a team as a code owner February 16, 2022 16:43
@joshwlewis joshwlewis merged commit f4e7ee2 into main Feb 16, 2022
@joshwlewis joshwlewis deleted the fix-yarn-cache-nesting branch February 16, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants