Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running "npm ci" when "npm-shrinkwrap.json" is found on the project directory #938

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

fjorgemota
Copy link
Contributor

Original reasoning, discussion and so on is on the PR #899.

I'm just opening this new PR because for some reason Github didn't recognize the new commit on the fork.

@fjorgemota fjorgemota requested a review from a team as a code owner September 1, 2021 19:51
@fjorgemota
Copy link
Contributor Author

Whoops, thanks for fixing the CHANGELOG issue. I hadn't observed that the ID of the PR would be a problem. 👍

I'll await for this PR to be finally merged. Thanks for the review, too. :)

@joshwlewis joshwlewis merged commit 5b3fac9 into heroku:main Sep 1, 2021
@joshwlewis
Copy link
Member

No worries at all. Thanks for the patience and contribution.

@joshwlewis joshwlewis mentioned this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants