Skip to content

Conversation

@jmorrell
Copy link
Contributor

@jmorrell jmorrell commented May 24, 2019

Depends on #668

This replaces the Nodebin calls by shelling out to the resolve binary. These tests are called by the automation half of Nodebin to validate new releases before they are made available on the platform.

The TEST_ALL_NODE_VERSIONS version is not directly used anywhere, but can be useful for maintainers iterating on the Node metrics plugin.

❯ bundle exec rspec spec/nodebin                         
Running tests for Node versions: 6.17.1, 8.16.0, 9.11.2, 10.15.3, 11.15.0
...
❯ TEST_NODE_VERSION=11.0.0 bundle exec rspec spec/nodebin                        
Running tests for Node versions: 11.0.0
...
❯ TEST_ALL_NODE_VERSIONS=true bundle exec rspec              
Running tests for Node versions: 10.0.0, 10.1.0, 10.10.0, 10.11.0, 10.12.0, 10.13.0, 10.14.0, 10.14.1, 10.14.2, 10.15.0, 10.15.1, 10.15.2, 10.15.3, 10.2.0, 10.2.1, 10.3.0, 10.4.0, 10.4.1, 10.5.0, 10.6.0, 10.7.0, 10.8.0, 10.9.0, 11.0.0, 11.1.0, 11.10.0, 11.10.1, 11.11.0, 11.12.0, 11.13.0, 11.14.0, 11.15.0, 11.2.0, 11.3.0, 11.4.0, 11.5.0, 11.6.0, 11.7.0, 11.8.0, 11.9.0, 12.0.0, 12.1.0, 12.2.0, 12.3.0, 12.3.1, 6.0.0, 6.1.0, 6.10.0, 6.10.1, 6.10.2, 6.10.3, 6.11.0, 6.11.1, 6.11.2, 6.11.3, 6.11.4, 6.11.5, 6.12.0, 6.12.1, 6.12.2, 6.12.3, 6.13.0, 6.13.1, 6.14.0, 6.14.1, 6.14.2, 6.14.3, 6.14.4, 6.15.0, 6.15.1, 6.16.0, 6.17.0, 6.17.1, 6.2.0, 6.2.1, 6.2.2, 6.3.0, 6.3.1, 6.4.0, 6.5.0, 6.6.0, 6.7.0, 6.8.0, 6.8.1, 6.9.0, 6.9.1, 6.9.2, 6.9.3, 6.9.4, 6.9.5, 7.0.0, 7.1.0, 7.10.0, 7.10.1, 7.2.0, 7.2.1, 7.3.0, 7.4.0, 7.5.0, 7.6.0, 7.7.0, 7.7.1, 7.7.2, 7.7.3, 7.7.4, 7.8.0, 7.9.0, 8.0.0, 8.1.0, 8.1.1, 8.1.2, 8.1.3, 8.1.4, 8.10.0, 8.11.0, 8.11.1, 8.11.2, 8.11.3, 8.11.4, 8.12.0, 8.13.0, 8.14.0, 8.14.1, 8.15.0, 8.15.1, 8.16.0, 8.2.0, 8.2.1, 8.3.0, 8.4.0, 8.5.0, 8.6.0, 8.7.0, 8.8.0, 8.8.1, 8.9.0, 8.9.1, 8.9.2, 8.9.3, 8.9.4, 9.0.0, 9.1.0, 9.10.0, 9.10.1, 9.11.0, 9.11.1, 9.11.2, 9.2.0, 9.2.1, 9.3.0, 9.4.0, 9.5.0, 9.6.0, 9.6.1, 9.7.0, 9.7.1, 9.8.0, 9.9.0
...

Copy link
Contributor

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's really quite good. Made some minor comments. The only one I would strongly request that you add is for error checking on your shell out commands (i.e. the run! command). You're welcome to take or leave the style comments.

@jmorrell jmorrell requested a review from schneems May 24, 2019 20:30
Copy link
Contributor

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jmorrell jmorrell changed the base branch from deprecate-nodebin-2 to master May 28, 2019 18:58
@jmorrell jmorrell merged commit 8e3236a into master May 28, 2019
@jmorrell jmorrell deleted the deprecate-nodebin-3 branch May 28, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants