Resolve more inconsistencies with version selection #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data from the dark-launch of the new resolve logic shows the same result 99.5% of the time. There are two classes where things differ: - Version numbers of leading v's. Ex: v10.15.3 - Cases where the resolve function fails and the nodebin request succeeds To that end I've updated the underlying semver library to correctly parse the leading v's and bumped the version. I've also written a retry loop around resolve to match the `--retry 5` option in the curl request
jkutner
reviewed
May 22, 2019
lib/binaries.sh
Outdated
| return 0 | ||
| else | ||
| n=$((n+1)) | ||
| sleep 1 |
Contributor
There was a problem hiding this comment.
might be good to backoff here, even if it's just linear. like sleep $((n+1))
jkutner
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data from the dark-launch of the new resolve logic shows the same result 99.5% of the time. There are two cases where things differ:
v10.15.3To that end I've updated the underlying semver library to correctly parse the leading v's and bumped the version.
I've also written a retry loop around resolve to match the
--retry 5option in the curl request.