Resolve the known behavior mismatches between nodebin and the go logic #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorrell
force-pushed
the
fix-resolve-mismatches
branch
from
63df938 to
56fdfe9
Compare
jkutner
reviewed
May 10, 2019
|
|
||
| for _, rel := range filtered { | ||
| if rel.version.Equal(resolvedVersion) { | ||
| if rel.version.Equals(resolvedVersion) { |
Contributor
There was a problem hiding this comment.
I think the convention in stdlib is Equal (like bytes.Equal), but I already hate myself for even bringing this up
Contributor
Author
There was a problem hiding this comment.
That's inherited from the library I forked for this. I'll make a note to change that as I polish it up and document it :)
jkutner
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous library: github.com/Mastermind/semver proved to not match the behavior of https://github.com/npm/node-semver in some important ways. The dark launch showed that ~1% of all node builds would either fail, or get the wrong version. Examples:
I forked https://github.com/blang/semver and cribbed the logic from the Node library as https://github.com/jmorrell/semver
Let's dark-launch this V2 and see if we are still not matching up anywhere.