Clean up script metrics and logging #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorrell
commented
Apr 9, 2019
| meta_set "build-script" "$build" | ||
| meta_set "postinstall-script" "$postinstall" | ||
| meta_set "heroku-prebuild-script" "$heroku_prebuild" | ||
| meta_set "heroku-postbuild-script" "$heroku_prebuild" |
Contributor
Author
There was a problem hiding this comment.
🤦♂️ well that explains the oddness I was seeing in the logs the other day
jkutner
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These metrics were used to gauge difficulty of the run build breaking change: #583 and are no longer useful
Storing them in the metadata so that they get logged out is still useful, so let's keep that.
This also changes the ordering so that it logs out the scripts before they are run, so that if the build fails, the command that failed will also be captured.