Upgrade to FFMPEG 5.1.2 and pull our own FFMPEG builds from S3 #30
Conversation
schneems
force-pushed
the
schneems/update-ffmpeg-binaries
branch
5 times, most recently
from
caf8030
to
8bbcc0c
Compare
Previously we were hosting a `.deb` with the updates from #28 we are now using a `tar.gz`. We can get rid of the cache as we have to download from S3 either way. This change is gated on the full rollout of https://devcenter.heroku.com/changelog-items/2547 as #28 relies on updated system packages to be present.
schneems
force-pushed
the
schneems/update-ffmpeg-binaries
branch
from
8bbcc0c
to
6cd0e14
Compare
schneems
force-pushed
the
schneems/update-ffmpeg-binaries
branch
from
f73e6e2
to
031dfc6
Compare
schneems
force-pushed
the
schneems/update-ffmpeg-binaries
branch
2 times, most recently
from
823a922
to
3b8634c
Compare
schneems
force-pushed
the
schneems/update-ffmpeg-binaries
branch
from
3b8634c
to
05ba412
Compare
There was a problem hiding this comment.
IMO we should drop the mp4 file from the fixtures; no need to have binaries in the repo. We can use e.g. https://samples.ffmpeg.org/MPEG-4/turn-on-off.mp4 directly (you can ffprobe https://samples.ffmpeg.org/MPEG-4/turn-on-off.mp4).
If you remove it, make sure to rewrite history to drop the commit, or the binary data will remain in history.
dzuelke
changed the title
bin/compile
Outdated
| else | ||
| CACHED_SFFMPEG=$SFFMPEG_VERSION | ||
| fi | ||
| SFFMPEG_VERSION="5.1.2" |
There was a problem hiding this comment.
Can we rename this to FFMPEG_VERSION please? :)
There was a problem hiding this comment.
Updated, check and resolve please.
It's 443 KB and means that we don't have to depend on the network failing or that site going down or any other host of potential testing inconsistencies. I think the cost of a slightly larger git repo is worth it. If we start adding tons of other fixtures then I'll be happy to remove. If you're strongly wanting to remove it still for file size, I would suggest we use a shorter/smaller video instead. |
schneems
changed the title
- Remove cache of deb packages Previously we stored a cache of the static ffmpeg binary, however both the cache and the binary are stored on S3 so this does not improve compile times. By moving to not use the cache and deleting old contents we can reduce cache size while preserving compile times - Move location of `dpkg -x` to be logically consistent with installing poppler Previously we were installing ffmpeg and poppler via the apt-get mechanism. With the move to have FFMPEG be a simple curl to disk, it makes more sense to have the `dpkg -x` logic be with the poppler download code. - Add additional logging Log download and install for poppler and ffmpegcache. Adds the version of ffmpeg to the log output.
schneems
force-pushed
the
schneems/update-ffmpeg-binaries
branch
from
272a179
to
a3b1aa4
Compare
|
Please re-review. Let's hold of on giving an approval though until we're sure dogwood is fully rolled out. I added instructions for using this branch in the description. |
Previously we were hosting a
.debwith the updates from #28 we are now using atar.gz.We can get rid of the cache as we have to download from S3 either way. This change is gated on the full rollout of https://devcenter.heroku.com/changelog-items/2547 as #28 relies on updated system packages to be present.
It's worth noting that the common runtime and private spaces runtime update their stack images at different intervals. Due to this, merge will be delayed.
Developers can test use this branch before merge by running:
Once merged, you should switch back or your app will not receive updates or security fixes. You can switch back by running:
If you're using pipelines, make sure you run commands on your staging app so binaries are properly promoted.