This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Strip ANSI characters when fitting terminal width #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
+ Coverage 95.79% 95.82% +0.03%
==========================================
Files 76 76
Lines 1570 1582 +12
Branches 297 298 +1
==========================================
+ Hits 1504 1516 +12
Misses 63 63
Partials 3 3
Continue to review full report at Codecov.
|
HaraldNordgren
force-pushed
the
align_releases_length
branch
3 times, most recently
from
a85c05e to
cbe9a48
Compare
HaraldNordgren
changed the title
HaraldNordgren
force-pushed
the
align_releases_length
branch
from
cbe9a48 to
7f09cd1
Compare
HaraldNordgren
force-pushed
the
align_releases_length
branch
from
7f09cd1 to
f372ce6
Compare
1 similar comment
HaraldNordgren
force-pushed
the
align_releases_length
branch
from
f372ce6 to
a59397a
Compare
jdx
approved these changes
Apr 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug introduced in #216. I noticed that the previous fix was not taking all ANSI color sequences into account when calculating the lengths. The effect of this is that the table output will be still be aligned, but too narrow.
In the original implementation that stretched over
heroku-appsandheroku-cli-utilthe ANSI stripping was done implicitly through https://github.com/heroku/heroku-cli-util/blob/v8.0.0/lib/table.js#L74. I forgot to include that when migrating that code to the current implementation.Here I am creating a fix which is to call
stripAnsi(formattedValue)when calculating the optimization lengths.The rest of the PR is for increasing testability of the code. The older tests won't fail for this scenario since colors are turned off by default in the mock scenario.