chore: add setup-node to pack-upload and release-homebrew workflows - #3879
Merged
michaelmalave merged 1 commit intoAug 19, 2026
Merged
Conversation
W-23445979 (v12 Node 24 workflow update) is mostly landed on v12.0.0 via PR #3877 (CI matrix [22.x, 24.x], Node 20 dropped, existing setup-node steps pinned to 24.x). The remaining gap: pack-upload.yml (pack_deb, pack_tarballs, upload-deb-and-tarballs jobs) and release-homebrew.yml run `npm ci` with no setup-node step of their own, so they silently inherit the ambient GitHub runner Node instead of the repo's pinned 24.x baseline. Add an explicit actions/setup-node@v6 step (node-version: 24.x, cache: npm) immediately after checkout in each of those jobs, matching the exact action ref and step shape already used everywhere else in this repo's workflows on v12.0.0 (ci.yml, release.yml, create-cli-release.yml, promote.yml, tag-create-github-release.yml, devcenter-doc-update.yml). cache-invalidation.yml and tps-record-release.yml are left untouched (Node-independent). No cache key references a node version, so no cache-key change is needed.
michaelmalave
deleted the
worker/gus-a07EE00002ekf5CYAQ-2026-08-18-task-1
branch
August 19, 2026 19:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin an explicit Node.js runtime in the release/pack workflows that run
npm ciwithout asetup-nodestep of their own, so those jobs build against Node 24 instead of the ambient GitHub-runner Node. These reusable/dispatched workflows do not inherit a Node context from their callers, so each needs its ownsetup-node.actions/setup-node@v6(node-version: 24.x,cache: npm) to the three pack jobs inpack-upload.yml(each runsnpm ci).setup-node@v6step torelease-homebrew.ymlbefore its install.@v6to match the version every othersetup-nodestep onv12.0.0already uses (no new action-version drift).Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
Workflow YAML only — not exercised by the unit suite; CI on this branch is the real verification (the pack and homebrew jobs should now provision Node 24.x before
npm ci). Before opening, confirmed the diff is scoped and consistent with the release line:Steps:
npm ci.Screenshots (if applicable)
N/A
Related Issues
GUS work item: W-23445979 — [CLI] v12: Update GitHub Actions workflows to Node 24