Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* WIPWIP * WIP * WIP * WIP * WIP * Move build_output to external module * Fix command formatting * Changelog and integration tests * Reduce boilerplate with Section::say_with_details * Update build output internals - Add module docs - Rename `header` to `buildpack_name` - Rename internal lookatme to look_at_me - Move `section::Section` and `section::RunCommand` to top level structs - Move internal timing related structs to `time` module * Add ability to get command prefix for BYO commands * Change `Quiet` to `Silent` Originally I thought "silent" and "stream" might be too close (both start with an "s") but mean basically opposite things. However, "quiet" implies there's some noise, versus "silent" indicates there's nothing to the output. * Fix no output on installing bundler I was not outputting anything when installing bundler by mistake (part of the reason for wanting to change "quiet" to "silent"). Before this commit: ``` # Heroku Ruby Buildpack - Ruby version `3.1.3` from `default` - Installing [------] (5.577s) - Bundler version `2.4.5` from `default` - Bundle install - Running `BUNDLE_BIN="/layers/heroku_ruby/gems/bin" BUNDLE_CLEAN="1" BUNDLE_DEPLOYMENT="1" BUNDLE_GEMFILE="/workspace/Gemfile" BUNDLE_PATH="/layers/heroku_ruby/gems" BUNDLE_WITHOUT="development:test" bundle install` Fetching gem metadata from https://rubygems.org/.. Fetching rake 13.0.6 Installing rake 13.0.6 Using bundler 2.4.5 Fetching rack 2.2.3 Fetching webrick 1.7.0 Installing webrick 1.7.0 Installing rack 2.2.3 Bundle complete! 3 Gemfile dependencies, 4 gems now installed. Gems in the groups 'development' and 'test' were not installed. Bundled gems are installed into `/layers/heroku_ruby/gems` - Done (6.637s) - Setting default processes(es) - Detecting gems - Running `bundle list` [-] (0.243s) - Detected rack app (`rack` gem and `config.ru` at root of application) - Rake assets install - Cannot run rake tasks (no Rakefile) ! Help: Add `Rakefile` to your project to enable - Done (finished in 13.572s) ``` After this commit: ``` # Heroku Ruby Buildpack - Ruby version `3.1.3` from `default` - Installing [----] (3.852s) - Bundler version `2.4.5` from `default` - Running `gem install bundler --version 2.4.5` [--] (1.081s) - Bundle install - Running `BUNDLE_BIN="/layers/heroku_ruby/gems/bin" BUNDLE_CLEAN="1" BUNDLE_DEPLOYMENT="1" BUNDLE_GEMFILE="/workspace/Gemfile" BUNDLE_PATH="/layers/heroku_ruby/gems" BUNDLE_WITHOUT="development:test" bundle install` Fetching gem metadata from https://rubygems.org/.. Fetching rake 13.0.6 Installing rake 13.0.6 Fetching rack 2.2.3 Fetching webrick 1.7.0 Using bundler 2.4.5 Installing webrick 1.7.0 Installing rack 2.2.3 Bundle complete! 3 Gemfile dependencies, 4 gems now installed. Gems in the groups 'development' and 'test' were not installed. Bundled gems are installed into `/layers/heroku_ruby/gems` - Done (3.929s) - Setting default processes(es) - Detecting gems - Running `bundle list` [-] (0.168s) - Detected rack app (`rack` gem and `config.ru` at root of application) - Rake assets install - Cannot run rake tasks (no `Rakefile`) ! Help: Add `Rakefile` to your project to enable - Done (finished in 9.093s) ``` I wanted to show that we're calling `--version` but not the other args as they're just noise. To do this I split up adding args into a "visible" and "invisible" section. The code is commented accordingly. * Force font weight for "normal" colors #155 (comment) * Use dots for installing marker: ``` # Heroku Ruby Buildpack - Ruby version `3.1.3` from `default` - Installing ........... (8.230s) - Bundler version `2.4.5` from `default` - Running `gem install bundler --version 2.4.5` .... (1.333s) - Bundle install - Running `BUNDLE_BIN="/layers/heroku_ruby/gems/bin" BUNDLE_CLEAN="1" BUNDLE_DEPLOYMENT="1" BUNDLE_GEMFILE="/workspace/Gemfile" BUNDLE_PATH="/layers/heroku_ruby/gems" BUNDLE_WITHOUT="development:test" bundle install` Fetching gem metadata from https://rubygems.org/.. Fetching rake 13.0.6 Installing rake 13.0.6 Using bundler 2.4.5 Fetching rack 2.2.3 Fetching webrick 1.7.0 Installing webrick 1.7.0 Installing rack 2.2.3 Bundle complete! 3 Gemfile dependencies, 4 gems now installed. Gems in the groups 'development' and 'test' were not installed. Bundled gems are installed into `/layers/heroku_ruby/gems` - Done (5.845s) - Setting default processes(es) - Detecting gems - Running `bundle list` ... (0.240s) - Detected rack app (`rack` gem and `config.ru` at root of application) - Rake assets install - Cannot run rake tasks (no `Rakefile`) ! Help: Add `Rakefile` to your project to enable - Done (finished in 15.749s) ``` * Get rid of NOCOLOR_TMP hack #155 (comment) It also turns out we're not even using it, but might in the future. * Adjust comment to match updated progress style * Output getting started guide to GH actions on push * Don't emit builder pull in output * Fix spelling
- Loading branch information