improve the readability #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
approved these changes
Aug 15, 2023
|
Not really. :-) Depending on access typo (and what your architecture supports), you can implicitly use an MSR registers. |
mkroening
requested changes
Aug 15, 2023
There was a problem hiding this comment.
According to "25.4 GUEST-STATE AREA" in Intel® 64 and IA-32 Architectures Software Developer's Manual Volume 3C: System Programming Guide, Part 3, FS and GS are part of the processor state and not managed by KVM, so perhaps the msr exits are from some other source like explicit wrmsr and rdmsr? ("26.1 INSTRUCTIONS THAT CAUSE VM EXITS")
|
I know. But I don't think that we should use the GS register in case of a one-core system |
stlankes
changed the title
|
Ok, I removed the core local staff |
mkroening
approved these changes
Aug 15, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.