network drivers create directly TxToken / RxToken for smoltcp #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stlankes
force-pushed
the
net
branch
2 times, most recently
from
8cdb72b
to
4197cb6
Compare
stlankes
added a commit
to stlankes/hermit-rs
that referenced
this pull request
Jul 31, 2023
This feature is required for hermit-os/kernel#810. Without this feature, the CI isn't able to test the RTL8139 interface.
stlankes
added a commit
to stlankes/hermit-rs
that referenced
this pull request
Jul 31, 2023
This feature is required for hermit-os/kernel#810. Without this feature, the CI isn't able to test the RTL8139 interface.
stlankes
changed the title
mkroening
approved these changes
Aug 2, 2023
|
Yes, the last commit was not useful. I removed it. It is already part of our stack. See https://github.com/hermitcore/libhermit-rs/blob/master/src/fd/socket/tcp.rs#L355-L360 |
|
Ah, makes sense. Still, without this PR, we can reach 191.4 MiB/s, and with it we can only reach 77.1 MiB/s. Edit: Never mind, seems fine, the benchmark is just inconsistent. |
For this purpose, it was necessary to avoid the creation of dynamic objects of the driver. This means that during compilation it must be defined which network interface is used. If the feature `rtl8139` is activated, the driver for Realtek 8139 will be used. Otherwise the Virtio network interface will be used. using a exponential backoff to check the network device if exponential backoff has completed, the task will be blocked and waits for an network interrupt poll device before the device checks the future remove obsolete code network drivers create directly TxToken / RxToken for smoltcp For this purpose, it was necessary to avoid the creation of dynamic objects of the driver. This means that during compilation it must be defined which network interface is used. If the feature `rtl8139` is activated, the driver for Realtek 8139 will be used. Otherwise the Virtio network interface will be used. build Virtio network driver only if the feature `tcp` is set feature `tcp` must be activated to support any network interface remove compiler warnings remove compiler warnings remove compiler warnings use polling mode for read / write operations on a socket idle task enables network interrupt, while the read function disable it enable network interrupts, if a socket is blocking add missing import check device driver only, if the device is available remove compiler warnings add mmio support add dummy network interface for aarch64 add missing file for mmio support add check if the feature tcp is available revert block_on to the original version revise CI workflow to support the feature rtl8139
mkroening
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this purpose, it was necessary to avoid the creation of dynamic objects of the driver. This means that during compilation it must be defined which network interface is used. If the feature
rtl8139is activated, the driver for Realtek 8139 will be used. Otherwise the Virtio network interface will be used.