Condvar: Mark sys functions as extern "C" #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are declared in hermit-abi as extern "C" already. So the current definition without extern "C" is wrong.
bors bot
added a commit
that referenced
this pull request
Apr 21, 2022
414: Targets: Use none-elf instead of hermit llvm-target r=stlankes a=mkroening As discussed in hermit-os/hermit-rs#197 (comment), this way the kernel's `libhermit.a` has `OS/ABI: UNIX - System V` and the resulting application has `OS/ABI: <unknown: ff>`. This works for the Rust-toolchain as well as the C-toolchain. 422: Condvar: Mark sys functions as extern "C" r=stlankes a=mkroening They are declared in hermit-abi as extern "C" already. So the current definition without extern "C" is wrong. 424: Clippy: Enable and fix transmute_ptr_to_ptr r=stlankes a=mkroening Co-authored-by: Martin Kröning <mkroening@posteo.net> Co-authored-by: Martin Kröning <m.kroening@hotmail.de>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Apr 21, 2022
422: Condvar: Mark sys functions as extern "C" r=stlankes a=mkroening They are declared in hermit-abi as extern "C" already. So the current definition without extern "C" is wrong. 424: Clippy: Enable and fix transmute_ptr_to_ptr r=stlankes a=mkroening Co-authored-by: Martin Kröning <m.kroening@hotmail.de>
|
Build failed (retrying...): |
|
Build failed: |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are declared in hermit-abi as extern "C" already.
So the current definition without extern "C" is wrong.