Benchmarks and hermit-bench interface #708
Conversation
|
I wonder if the bench.json belongs into hermit-rs or rather the kernel directly. The later would allow for different benchmark sets for the kernel and hermit-rs (but I'm not sure if that is actually relevant), and maybe splitting the separation of the benchmarks as a collection and the execution is a good idea? |
My rational was, that the commands to execute the benchmarks are dependent on hermit-rs and should therefore be kept together. I think it would be a little odd to have the But I don't feel super strongly about it either way. |
|
Super nice! Thank you 🥳 |
|
|
||
| [target.'cfg(target_os = "hermit")'.dependencies] | ||
| hermit = { path = "../../hermit", default-features = false } | ||
|
|
||
| [features] | ||
| default = ["hermit/acpi", "hermit/pci", "hermit/smp", "hermit/tcp"] | ||
| default = ["hermit/acpi", "hermit/pci", "hermit/smp", "hermit/tcp", "hermit/udp", "hermit/pci-ids"] |
There was a problem hiding this comment.
Why does this need full PCI IDs?
| @@ -0,0 +1,40 @@ | |||
| #![allow(unused_imports)] | |||
There was a problem hiding this comment.
Why do we need these unused imports in so many files?
This PR adds the benchmarks which the kernel will call for its Continuous Benchmarking. It also adds the
bench.jsonfile, which specifies how these benchmarks are to be operated.