Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to OAI buld and platform flexibility #375

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

platini2
Copy link
Contributor

@platini2 platini2 commented Oct 2, 2024

Makes running OAI easier by:

  1. Single dockerimage for enb and gnb
  2. Allow to run multiple SDR (not only USRP)
  3. Allow to quickly change configuration by using gnb.conf / enb.conf generic filenames.

Copy link
Owner

@herlesupreeth herlesupreeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you very much for the PR. I have suggested some changes let me know what you think

.env Outdated

# Openairinterface nodeB Parameters
# SDR USRP/LIMESDR/BLADERF
SDRPLATFORM=USRP
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am against adding this here you can pass it in the docker-compose file. For example, when you deploy oai_enb.yaml you can embed the variable there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

.env Outdated
SDRPLATFORM=USRP

# LTE for eNB or NR for gNB
RADIO=LTE
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am against adding this here you can pass it in the docker-compose file. For example, when you deploy oai_enb.yaml you can embed the variable RADIO=LTE and when you use the file oai_gnb.yaml you can use RADIO=NR or something like that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


ARG SDRPLATFORM

RUN . ./oaienv && cd cmake_targets && \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest having this logic of selecting the SDRPLATFORM and RADIO in oai_init.sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the SDRPLATFORM is part of the build process as OAI compilations requires the platform to be build for.

oaignb.yaml Outdated
@@ -3,8 +3,10 @@ services:
oaignb:
build:
context: oai
dockerfile: gnb_dockerfile
image: docker_oai_gnb
dockerfile: all_dockerfile
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than building it here. I would suggest to build the image beforehand and use the image name here so that whenever you try between oaienb.yaml and oaignb.yaml the image doesnt get rebuilt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants