Upgrade memmap2 to latest version.#232
Merged
boxdot merged 1 commit intoheremaps:masterfrom Oct 26, 2022
Merged
Conversation
Collaborator
|
@hallahan the only things that is missing is a signoff of the changes from you. |
Contributor
|
We don't have signoff in this repo. 😀
Edit: Sorry, I confused the repo 😅
|
Collaborator
|
@hallahan in case you did not notice yet: You still need to sign the change off (see https://github.com/heremaps/flatdata/pull/232/checks?check_run_id=9059705472 ) |
Contributor
Author
|
Oh, I see. I was not familiar with this concept of sign off. I will amend the commit. |
Signed-off-by: Nick Hallahan <nick@theoutpost.io>
Contributor
Author
|
Signed off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I PRed switching to the maintained memmap2 in boxdot/osmflat-rs#67 .
This just bumps the version used in flatdata for parity.