Skip to content

[asl] Typecheck discarded impdef subprograms #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2025
Merged

[asl] Typecheck discarded impdef subprograms #1280

merged 2 commits into from
May 2, 2025

Conversation

hrutvik
Copy link
Collaborator

@hrutvik hrutvik commented Apr 29, 2025

Rather than discarding overridden impdef subprograms, ensure they are type-checked. In particular, give them fresh names so that they are never referred to, but still appear in the final type-checked specification.

@hrutvik hrutvik force-pushed the typecheck-impdefs branch from 47fc321 to d01b172 Compare April 29, 2025 12:09
@hrutvik hrutvik marked this pull request as ready for review April 29, 2025 12:51
HadrienRenaud
HadrienRenaud approved these changes Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@HadrienRenaud HadrienRenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hrutvik added a commit to hrutvik/herdtools7 that referenced this pull request Apr 30, 2025
@hrutvik
[asl][reference] Update changelog
aff2dd4 
For the following:
- herd#1275
- herd#1276
- herd#1277
- herd#1278
- herd#1279
- herd#1280
- herd#1282
- herd#1283
Roman-Manevich
Roman-Manevich approved these changes May 2, 2025
View reviewed changes
Copy link
Collaborator

@Roman-Manevich Roman-Manevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some minor comments.

@hrutvik hrutvik force-pushed the typecheck-impdefs branch from d01b172 to da11293 Compare May 2, 2025 12:40
@hrutvik hrutvik merged commit 8bd2962 into herd:master May 2, 2025
3 checks passed
@hrutvik hrutvik deleted the typecheck-impdefs branch May 2, 2025 12:54
hrutvik added a commit to hrutvik/herdtools7 that referenced this pull request May 7, 2025
@hrutvik
[asl][reference] Update changelog
17568f0 
For the following:
- herd#1275
- herd#1276
- herd#1277
- herd#1278
- herd#1279
- herd#1280
- herd#1282
- herd#1283
- herd#1290
- herd#1294
- herd#1295
@hrutvik hrutvik mentioned this pull request May 7, 2025
Merged
hrutvik added a commit to hrutvik/herdtools7 that referenced this pull request May 7, 2025
@hrutvik
[asl][reference] Update changelog
e1b867e 
For the following:
- herd#1275
- herd#1276
- herd#1277
- herd#1278
- herd#1279
- herd#1280
- herd#1282
- herd#1283
- herd#1290
- herd#1294
- herd#1295
maranget pushed a commit that referenced this pull request May 15, 2025
@hrutvik @maranget
[asl][reference] Update changelog
4d361c8 
For the following:
- #1275
- #1276
- #1277
- #1278
- #1279
- #1280
- #1282
- #1283
- #1290
- #1294
- #1295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HadrienRenaud HadrienRenaud HadrienRenaud approved these changes

@Roman-Manevich Roman-Manevich Roman-Manevich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hrutvik @HadrienRenaud @Roman-Manevich