Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extend the previous PR I did for Pointer Authentication Code to add the support for hash collisions, for example a program like this one:
may run without fault because of a hash collision between
pacda(x,0)
andpacdb(x,0)
. But this program:can't return without fault and
0:X2=1
because otherwise their is a contradiction about the same collision. And herd will return (ideally with some debug flags because this output is not possible in litmus):This PR is till not 100% finish, I still have some update to do, as example: ensure that the pretty printing by default is the same between
herd
andlitmus
like I did for the version without collisions, moving the docs frompac_tests
...