Skip to content

Added possiblity to use npm install options via config #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added possiblity to use npm install options via config #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3b6ed3
Added possiblity to use npm install options via config
piotr-cz Jan 21, 2020
2e346a1
Merge branch 'master' into feature/npm-options
piotr-cz Jan 21, 2020
285b494
Added installOptions in tests (but no dedicated test case)
piotr-cz Jan 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion LayerManagerPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const fs = require('fs');

const DEFAULT_CONFIG = {
installLayers: true,
installOptions: [],
exportLayers: true,
upgradeLayerReferences: true,
exportPrefix: '${AWS::StackName}-'
Expand Down Expand Up @@ -63,10 +64,11 @@ class LayerManagerPlugin {

installLayer(path) {
const nodeLayerPath = `${path}/nodejs`;
const installArgsString = this.config.installOptions ? this.config.installOptions.join(' ') : '';

if (fs.existsSync(nodeLayerPath)) {
verbose(this, `Installing nodejs layer ${path}`);
execSync('npm install', {
execSync(`npm install ${installArgsString}`, {
stdio: 'inherit',
cwd: nodeLayerPath
});
Expand Down
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,10 @@ You may customize the features by adding a `layerConfig` object under `custom`,
custom:
layerConfig:
installLayers: <boolean>
installOptions: <array>
exportLayers: <boolean>
upgradeLayerReferences: <boolean>
exportPrefix: <prefix used for the names of the exported layers>
```

By default, all config options are true and the `exportPrefix` is set to `${AWS:StackName}-`.
By default, all config options are true, the `exportPrefix` is set to `${AWS:StackName}-` and installOptions is an empty array.
1 change: 1 addition & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const DEFAULT_CONFIG = {
exportLayers: true,
exportPrefix: '${AWS::StackName}-',
installLayers: true,
installOptions: [],
upgradeLayerReferences: true
};

Expand Down