Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: date with locale support #461

Merged
merged 5 commits into from
Oct 7, 2024
Merged

fix: date with locale support #461

merged 5 commits into from
Oct 7, 2024

Conversation

sebastianthulin
Copy link
Member

No description provided.

NiclasNorin
NiclasNorin requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@NiclasNorin NiclasNorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well coded. Is there any reason not to type the parameters to the setter functions?

We do time() in 3 places, should this be a property?

Is it worth checking timezone_identifiers_list to make sure time zone is a valid value?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sebastianthulin sebastianthulin merged commit dc0b5b1 into main Oct 7, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiclasNorin NiclasNorin NiclasNorin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianthulin @NiclasNorin