Search on module description and title

[perifer]

This was mentioned by the editors on Höör: It would be nice if it was possible to search on the module description. Seems to me like a very good idea.

When testing this I found that the search seemed very inconsist. I'm not sure what it matches on actually. I would have guessed titles but that doesn't seem to be the case.

[perifer]

I found the reason for the broken search: https://github.com/helsingborg-stad/Modularity/blob/master/source/php/Search.php#L96

I can't understand what moduleSearch() tries to do actually so I can't debug this. But completely disabling this at least brings back consistent results. With this enabled the page count is for example wrong, and the result is mixed with other post types.

[Svanmark]

ModuleSearch is supposed to search modularity modules. I think this may be broken since Modularity 2.0.

…

1 juni 2017 kl. 10:20 skrev Anders Fajerson ***@***.***>: I found the reason for the broken search: https://github.com/helsingborg-stad/Modularity/blob/master/source/php/Search.php#L96 <https://github.com/helsingborg-stad/Modularity/blob/master/source/php/Search.php#L96> I can't understand what moduleSearch() tries to do actually so I can't debug this. But completely disabling this at least brings back consistent results. With this enabled the page count is for example wrong, and the result is mixed with other post types. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAb7Ck4uJCTRKLxK6Hl5TZOS72mX4vJPks5r_nQzgaJpZM4LlxpU>.

[perifer]

Not sure, I reported inconsistent search on Jan 17. Inconsistent could still mean that I still doesn't understand exactly what is going on though.

[perifer]

#20 is merged, but this is not resolved. Can you reproduce the oddities I'm seeing or is it just I who misinterpreters the functionality?

[sebastianthulin]

I have reproduced the "mixed post types" issue. Looking into a more straight forward solution here.