Merge pull request #686 from helsingborg-stad/fix/post-module-max-amo…

…unt-of-posts fix: post module maximum amount of posts to get
helsingborg-stad · Nov 1, 2024 · 4777b86 · 4777b86
2 parents dfec9ae + cf7a195
commit 4777b86
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/source/php/AcfFields/json/mod-posts-source.json b/source/php/AcfFields/json/mod-posts-source.json
@@ -164,15 +164,15 @@
             "name": "posts_count",
             "aria-label": "",
             "type": "number",
-            "instructions": "Set to -1 to show all",
+            "instructions": "Amount of posts to show (Maximum of 100)",
             "required": 1,
             "conditional_logic": 0,
             "wrapper": {
                 "width": "",
                 "class": "",
                 "id": ""
             },
-            "default_value": -1,
+            "default_value": 10,
             "min": "",
             "max": "",
             "step": "",

diff --git a/source/php/AcfFields/php/mod-posts-source.php b/source/php/AcfFields/php/mod-posts-source.php
@@ -176,15 +176,15 @@
             'name' => 'posts_count',
             'aria-label' => '',
             'type' => 'number',
-            'instructions' => __('Set to -1 to show all', 'modularity'),
+            'instructions' => __('Amount of posts to show (Maximum of 100)', 'modularity'),
             'required' => 1,
             'conditional_logic' => 0,
             'wrapper' => array(
                 'width' => '',
                 'class' => '',
                 'id' => '',
             ),
-            'default_value' => -1,
+            'default_value' => 10,
             'min' => '',
             'max' => '',
             'step' => '',

diff --git a/source/php/Module/Posts/Helper/GetPosts.php b/source/php/Module/Posts/Helper/GetPosts.php
@@ -182,7 +182,9 @@ private function getPostArgs(array $fields, int $page)
 
         // Number of posts
         if (isset($fields['posts_count']) && is_numeric($fields['posts_count'])) {
-            $getPostsArgs['posts_per_page'] = $fields['posts_count'];
+            $postsPerPage = ($fields['posts_count'] == -1 || $fields['posts_count'] > 100) ? 100 : $fields['posts_count'];
+
+            $getPostsArgs['posts_per_page'] = $postsPerPage;
         }
 
         // Apply pagination