Support custom root certificate via $SSL_CERT_FILE #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmello
changed the title
tetigi
approved these changes
Sep 26, 2023
|
can we document this in the book (in the reference section) @asmello? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables using the system native certificate tooling to pick up on custom root certificates automatically.
I've also refactored the Artifactory registry implementation a bit. It's more efficient now, as it reuses a connection pool between requests, but still creates a new client per dependency when running the install command. This can be improved to one client per registry, which I'll probably implement in a dedicated PR.