Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LocalRegistry for testing #23

Merged
merged 7 commits into from
Aug 30, 2023
Merged

Implement LocalRegistry for testing #23

merged 7 commits into from
Aug 30, 2023

Conversation

uschi2000
Copy link
Contributor

No description provided.

@uschi2000 uschi2000 requested a review from mara-schulke August 30, 2023 13:12
@uschi2000 uschi2000 changed the title Rfink/local registry Implement LocalRegistry for testing Aug 30, 2023
Copy link
Contributor

@mara-schulke mara-schulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits but generally it lgtm!

src/registry/local.rs Outdated Show resolved Hide resolved
src/registry/test-data/test-api-0.1.0.tgz Outdated Show resolved Hide resolved
src/registry/local.rs Outdated Show resolved Hide resolved
src/package.rs Show resolved Hide resolved
@mara-schulke
Copy link
Contributor

mara-schulke commented Aug 30, 2023

How / when is the local registry used through the cli? Can we guard it with compile guards like #[cfg(debug_assertions)] so it is not compiled into release builds?

Robert Fink added 2 commits August 30, 2023 15:55
@uschi2000 uschi2000 requested a review from mara-schulke August 30, 2023 15:17
@uschi2000 uschi2000 merged commit 5376053 into main Aug 30, 2023
@uschi2000 uschi2000 deleted the rfink/local-registry branch August 30, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants