-
Notifications
You must be signed in to change notification settings - Fork 16
Add Dockerfile for registry #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Shouldn't the |
Hei @BlowaXD, tysm for your contribution! 😊 |
I agree with @tomkarw's comment, otherwise this looks good to me 😊 |
Sure, I did first assume that someone would have wanted to build from the same directory Moving it to Having this COPY .. . or using this command to build docker build -t registry . --file registry/Dockerfile I don't know which UX you want to provide, I do not see an alternative because of the registry requiring |
I'd go with I think the issue is more general, we have a CLI, a registry, and they share some common parts. This clearly indicates 3 crates ( |
Edited the PR, I gave a command in the |
- added README.md in registry project with docker build command - added .dockerignore to ignore **/target/**
Awesome, thank you @BlowaXD! |
This should partially solve #45
Additions
registry/Dockerfile
registry/.dockerignore
ignoring**/target/**
to avoid having to sending too much files to contextI decided to manually install protobuff deps to have an easy way to manage the protobuf compiler version