Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Cargo.lock to the registry crate #190

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Add a Cargo.lock to the registry crate #190

merged 3 commits into from
Dec 7, 2023

Conversation

qsantos
Copy link
Contributor

@qsantos qsantos commented Dec 7, 2023

This PR:

  • adds registry/Cargo.lock, which was ignored, to the repository
  • remove unused dependencies (including sqlx, which will need to be re-added when it is actually used); this will make compilation faster until these dependencies are actually needed
  • make the S3 storage feature non-default; this should make compilation faster assuming we generally just want a filesystem storage
  • ignores the proto/vendor/ directory which is generated by build.rs

If you think any of these should not be done, I'll just remove the corresponding commit.

@qsantos qsantos requested a review from mara-schulke December 7, 2023 12:14
@qsantos qsantos self-assigned this Dec 7, 2023
@mara-schulke
Copy link
Contributor

We want s3 by default!

Copy link
Contributor

@mara-schulke mara-schulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just the default feature is important before merging

registry/Cargo.toml Outdated Show resolved Hide resolved
@qsantos qsantos force-pushed the registry-cargo-lock branch from 4db799a to 6258af9 Compare December 7, 2023 13:01
@qsantos qsantos force-pushed the registry-cargo-lock branch from 6258af9 to dfbc1da Compare December 7, 2023 14:37
@qsantos qsantos enabled auto-merge December 7, 2023 14:37
@qsantos qsantos merged commit 8d47192 into main Dec 7, 2023
6 checks passed
@qsantos qsantos deleted the registry-cargo-lock branch December 7, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants