Allows building registry #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfbs
added
complexity::low
This allows for compiling the registry: - Adds tonic dependency - Adds prost dependency - Adds `registry` to crate workspace
mara-schulke
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for compiling the registry.
tonicandprostdependencies. These are needed for thebuffrsgenerated code to compile correctly.registryto crate workspace. This allows for a better dev experience (they share atargetfolder, meaning that you don't have to recompile shared dependencies twice) and allows the tests to be included in the CI.Some open questions:
tonicandprostas direct dependencies of the registry for it to build. Is that the way to go? We could circumvent this, by re-exportingtonicandprostfrom buffrs (asbuffrs::tonicandbuffrs::prost) and minimally rewriting generated files. This might allow for a smoother experience, because it means you are not confronted with errors.