Remove kafkamocker from app.src

[varnerac]

There is no reason to start kafkamocker outside of testing. This removes kafkamocker from ekaf.app.src.

[bosky101]

Hi. You're right. But I'm not familiar with rebar3. Is there a way specifically to say certain apps need to start for test env?

Simply removing the kafkamocker app will break current builds.

[bosky101]

Actually perhaps the tests alone can explicitly start it. Feel free to make an additional change, that adds application:start(kafkamocker) to ekaf_tests.erl 's pre-test init setup.

[varnerac]

Have you tried this patch? Removing kafkamocker from app.src doesn't break the build. There's no reason for it to be in .app.src. The unit tests start it explicitly, like this: https://github.com/helpshift/ekaf/blob/master/test/ekaf_tests.erl#L77

[varnerac]

I note that you closed the rebar3 issue. This issue doesn't affect rebar3. This works even if you stay on the deprecated version of rebar.

[bosky101]

Cool. Just tested it here https://travis-ci.org/bosky101/ekaf/builds/129665003 Wish travis had a better way to run tests against each pull request. Need to get about doing so over a weekend.

Thanks.