Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.1 #254

Merged
merged 2 commits into from
Mar 30, 2017
Merged

0.8.1 #254

merged 2 commits into from
Mar 30, 2017

Conversation

LaurentGoderre
Copy link
Contributor

No description provided.

@LaurentGoderre
Copy link
Contributor Author

@jonschlinkert @doowb any objections?

@jonschlinkert
Copy link
Member

Can you get away with just bumping bower.json to 0.8.0? other than that, seems fine to me

@LaurentGoderre
Copy link
Contributor Author

@jonschlinkert no because I am trying to release a new commit since 0.8.0

@jonschlinkert
Copy link
Member

I am trying to release a new commit since 0.8.0

Why? Sorry if I'm missing something obvious, but bower.json has nothing to do with npm. publishing a new version on npm won't effect bower in any way (and bower.json won't get published to npm), and bower doesn't look at npm or package.json. Bower only looks at github

@LaurentGoderre
Copy link
Contributor Author

I need that new commit in grunt-assemble so I need a new npm version

@doowb
Copy link
Member

doowb commented Mar 30, 2017

I need that new commit in grunt-assemble so I need a new npm version

Can you explain this a little more? Which new commit are you referring to? handlebars-helpers@0.8.0 is already used in assemble-handlebars@0.4.1 and that's already used in the latest grunt-assemble@0.6.3. Making a change in bower.json shouldn't have any affect on those modules.

@LaurentGoderre
Copy link
Contributor Author

I need this commit in a release 0ad46f8

@doowb
Copy link
Member

doowb commented Mar 30, 2017

That makes more sense now, sorry I didn't notice the other commits. We need to also run verb so the readme is updated (there was another change that added a new helper and will change some of the links).

There are also some other PRs that might be able to go into a patch version. I'll take a look at those today and see if we can include any of them. Then since bumping the version is part of what we do when releasing, I can just do it at that time. Thanks for pointing it out though.

@jonschlinkert
Copy link
Member

yeah makes more sense now, thanks for the detail.

There are also some other PRs that might be able to go into a patch version.

awesome, thanks @doowb!

@doowb doowb merged commit 1a3e310 into helpers:master Mar 30, 2017
@doowb
Copy link
Member

doowb commented Mar 30, 2017

@LaurentGoderre merged and published. You should be able to pull down the latest grunt-assemble and it'll handlebars-helpers 0.8.1.

@LaurentGoderre LaurentGoderre deleted the v0.8.1 branch March 31, 2017 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants