Set font color on annotation class to override github dark mode color #23
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you share a screenshot of what this looks like in dark mode / light mode ? |
|
Light Mode Dark Mode High Contrast Dark Mode |
|
@helmus @kaspars-ozols Can you merge this? |
|
Thank you! |
|
@helmus Can you update the chrome extension also? The change doesn't seem to be showing up there yet |
|
I will release the new version this week. Prs to automate this process
welcome.
…On Sun, Feb 13, 2022, 10:38 AM Ari Abramowitz ***@***.***> wrote:
@helmus <https://github.com/helmus> Can you update the chrome extension
also? The change doesn't seem to be showing up there yet
—
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH6QHY3LKWI6442LBOMNYLU273C3ANCNFSM5N2LZ2IA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@helmus Can you take a look at this? The extension still has not updated |
|
version 1.8.0 is pending review on the chrome store. |
|
This has been released: https://chrome.google.com/webstore/detail/jira-hotlinker/lbifpcpomdegljfpfhgfcjdabbeallhk?hl=en |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix the annotation box is hard to read in dark mode, and unreadable in high contrast dark mode
Related to (but not a fix for) #22