Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-negative sample size for linspace/logspace #995

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

neosunhan
Copy link
Collaborator

Description

Allow linspace to be called with 0 sample size. This also fixes an inconsistency with the documentation, which already allows num to be non-negative.

Issue/s resolved: #994

Type of change

  • New feature (non-breaking change which adds functionality)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

skip ci

@ghost
Copy link

ghost commented Jul 15, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #995 (2dfd591) into main (05a2acd) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   91.12%   91.10%   -0.03%     
==========================================
  Files          65       65              
  Lines        9976     9976              
==========================================
- Hits         9091     9089       -2     
- Misses        885      887       +2     
Flag Coverage Δ
gpu ?
unit 91.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/factories.py 99.24% <100.00%> (ø)
heat/core/tests/test_suites/basic_test.py 91.26% <0.00%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a2acd...2dfd591. Read the comment docs.

@neosunhan neosunhan changed the title Enable non-negative sample size Non-negative sample size for linspace/logspace Jul 18, 2022
@neosunhan neosunhan marked this pull request as ready for review July 18, 2022 12:16
@neosunhan neosunhan requested review from mtar and ClaudiaComito July 18, 2022 13:31
@Markus-Goetz Markus-Goetz merged commit 99aef73 into main Jul 20, 2022
@Markus-Goetz Markus-Goetz deleted the features/994-linspace-zero-samples branch July 20, 2022 13:05
@mtar mtar removed the PR talk label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable non-negative sample number in linspace and logspace
3 participants