-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/337 determinant #877
Conversation
Codecov Report
@@ Coverage Diff @@
## master #877 +/- ##
==========================================
+ Coverage 95.50% 95.52% +0.02%
==========================================
Files 64 64
Lines 9579 9617 +38
==========================================
+ Hits 9148 9187 +39
+ Misses 431 430 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great to me. Just a small change
@mtar i have changed the shape rules to line up with torch's results. can you check this again? |
@coquelin77 Thanks for addressing the wrong dimension of the result tensor. I was now able to reduce some lines of code due to a fix in master. |
Description
First implementation of determinant computation using Gaussian elimination with partial pivoting.
Issue/s resolved: #337
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no