Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I propose to implement a DNDarray method to return a 1-byte
torch.Tensor
strided as the original DNDarray global shape. At @ben-bou 's suggestion, we have been using this "proxy" tensor for sanitation, as it allows us to easily bypass many of the instance checks. It is also quite practical to assess the shape of the output DNDarray of any operation. See getitem/setitem, ormanipulations.tile()
for examples.Issue/s resolved: None. Implemented with an eye on long-term maintenance / minimizing repetitions / simplifying code.
Changes proposed:
DNDarray.__torch_proxy__()
dndarray
andmanipulations
withDNDarray.__torch_proxy__()
callsDNDarray.size
returningint
even ifDNDarray.ndim
is 0Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no