Dot product matrix vector ops + randn inf bugfix #820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dot
can multiply matrices and vectors nowrandn
bug is now hopefully fixed. tested up to memory limit of my personal machineIssue/s resolved: #817 #819
Changes proposed:
dot
uses matmul to handlematrix @ vector
inputsrandn
get a very small offset to move them away from 0. this should avoid theinf
values from showing up without changing the distribution very much at allType of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no